Fails to invoke `after_remove` callback when deleting associated record

[ekampp]

I have a class with a has_many association. I have a after_add and an after_remove callback on the association, like this:

# rails 4.2.0.alpha
has_many :character_levels,
  after_add: :log_adding_event,
  after_remove: :log_removing_event

def log_adding_event
  Log.create!({ event: "adding" })
end

def log_removing_event
  Log.create!({ event: "removing" })
end

When adding a character level, I can see that a Log instance is created. I can even replicate in tests. But when deleting an associated record, the callback isn't getting executed correctly:

Character.find(1).character_levels << CharacterLevel.find(1) 
# => Results in a Log record being created

Character.find(1).character_levels.delete(CharacterLevel.find(1))
# => Should result in a Log being created, but doesn't

[rafaelfranca]

delete doesn't run any callback. Does destroy works?

[ekampp]

No. End neither does clear, destroy_all, or delete_all

[ekampp]

Worth noting, I'm using Rails 4.2.0.alpha, so it might be a regression since last stable release.

[rafaelfranca]

Thanks for confirming

[ekampp]

No problem.

[ekampp]

All right. I found the problem. I was adding through an association. After moving the hooks around, they seem to be working correctly. Perhaps a note in the documentation?

[zenati]

@rafaelfranca Same problem using as:

has_many :lines, as: :lineable, after_add: :calculate_totals, after_remove: :calculate_totals

after_add works but not after_remove.

Any idea?

[zenati]

Hello @rafaelfranca, here is the content of active_record_master.rb template.

unless File.exist?('Gemfile')
  File.write('Gemfile', <<-GEMFILE)
    source 'https://rubygems.org'
    gem 'rails', github: 'rails/rails'
    gem 'arel', github: 'rails/arel'
    gem 'rack', github: 'rack/rack'
    gem 'i18n', github: 'svenfuchs/i18n'
    gem 'sqlite3'
  GEMFILE

  system 'bundle'
end

require 'bundler'
Bundler.setup(:default)

require 'active_record'
require 'minitest/autorun'
require 'logger'

# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
ActiveRecord::Base.logger = Logger.new(STDOUT)

ActiveRecord::Schema.define do
  create_table :papers do |t|
  end

  create_table :lines do |t|
    t.integer :lineable_id
    t.string :lineable_type
  end
end

class Paper < ActiveRecord::Base
  has_many :lines,
    as: :lineable,
    dependent: :destroy,
    after_add: :line_added,
    after_remove: :line_removed

  def line_added(line)
    logger.info '******** ADDING *********'
  end

  def line_removed(line)
    logger.info '******** REMOVING *********'
  end
end

class Line < ActiveRecord::Base
  belongs_to :lineable, polymorphic: true
end

class BugTest < Minitest::Test
  def test_association_stuff
    paper = Paper.create!

    [:destroy, :delete].each do |c|
      paper.lines << Line.create!
      paper.lines.last.send(c)
    end
  end
end

after_add is called (here twice) but not after_remove.