Skip to content

Loading…

Ruby 1.9.2 minitest is not applying our backtrace cleaner in tests #1575

Closed
dhh opened this Issue · 14 comments

8 participants

@dhh
Ruby on Rails member
dhh commented

When Turn is off, you get the full backtrace when a test fails. It's not scrubbed with the backtrace cleaner.

@faisal

I see this even if turn is on. See https://github.com/metaskills/mini_backtrace for a workaround and possible fix.

@reactormonk

This is pulled & fixed, could someone close it? ed1fb7a

@arunagw
Ruby on Rails member

@Tass i can't see this in code. :(

@rafaelfranca
Ruby on Rails member
@arunagw arunagw was assigned
@steveklabnik
Ruby on Rails member

@tass I'll gladly close it, since ed1fb7a seems to take care of things.

@steveklabnik steveklabnik reopened this
@steveklabnik
Ruby on Rails member

As was just pointed out to me, this hasn't landed in master yet. My bad!

@arunagw
Ruby on Rails member

Yeah. Actually This is not applied yet :-(

@frodsan

@arunagw any news? :)

@arunagw
Ruby on Rails member

I will try to work this week. Otherwise I will remove my name from assignee so anybody can pick this up :-)

@tenderlove
Ruby on Rails member

We don't need to monkey patch MT to fix this. Just add the backtrace cleaner method to the MT/Spec subclass (AS::TestCase).

@frodsan

@tenderlove but the filter_backtrace method is part of the MiniTest module. How would you do it?

@tenderlove
Ruby on Rails member

Ah, I see. filter_backtrace is a class method (I thought it was an instance method). Let me see what I can do about that.

@tenderlove
Ruby on Rails member

I've opened a pull request on minitest that would allow us to set our own filter object.

@arunagw
Ruby on Rails member

Closing this as it's fixed. #7861

@arunagw arunagw closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.