Ruby 1.9.2 minitest is not applying our backtrace cleaner in tests #1575

Closed
dhh opened this Issue Jun 8, 2011 · 14 comments

Comments

Projects
None yet
8 participants
@dhh
Member

dhh commented Jun 8, 2011

When Turn is off, you get the full backtrace when a test fails. It's not scrubbed with the backtrace cleaner.

@faisal

This comment has been minimized.

Show comment
Hide comment
@faisal

faisal Jul 24, 2011

I see this even if turn is on. See https://github.com/metaskills/mini_backtrace for a workaround and possible fix.

faisal commented Jul 24, 2011

I see this even if turn is on. See https://github.com/metaskills/mini_backtrace for a workaround and possible fix.

@reactormonk

This comment has been minimized.

Show comment
Hide comment
@reactormonk

reactormonk Mar 4, 2012

This is pulled & fixed, could someone close it? ed1fb7a

This is pulled & fixed, could someone close it? ed1fb7a

@arunagw

This comment has been minimized.

Show comment
Hide comment
@arunagw

arunagw Mar 6, 2012

Member

@tass i can't see this in code. :(

Member

arunagw commented Mar 6, 2012

@tass i can't see this in code. :(

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
Member

rafaelfranca commented Apr 28, 2012

@ghost ghost assigned arunagw Apr 28, 2012

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Apr 28, 2012

Member

@tass I'll gladly close it, since ed1fb7a seems to take care of things.

Member

steveklabnik commented Apr 28, 2012

@tass I'll gladly close it, since ed1fb7a seems to take care of things.

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Apr 28, 2012

Member

As was just pointed out to me, this hasn't landed in master yet. My bad!

Member

steveklabnik commented Apr 28, 2012

As was just pointed out to me, this hasn't landed in master yet. My bad!

@arunagw

This comment has been minimized.

Show comment
Hide comment
@arunagw

arunagw Apr 29, 2012

Member

Yeah. Actually This is not applied yet :-(

Member

arunagw commented Apr 29, 2012

Yeah. Actually This is not applied yet :-(

@frodsan

This comment has been minimized.

Show comment
Hide comment
@frodsan

frodsan Sep 12, 2012

Contributor

@arunagw any news? :)

Contributor

frodsan commented Sep 12, 2012

@arunagw any news? :)

@arunagw

This comment has been minimized.

Show comment
Hide comment
@arunagw

arunagw Sep 12, 2012

Member

I will try to work this week. Otherwise I will remove my name from assignee so anybody can pick this up :-)

Member

arunagw commented Sep 12, 2012

I will try to work this week. Otherwise I will remove my name from assignee so anybody can pick this up :-)

@tenderlove

This comment has been minimized.

Show comment
Hide comment
@tenderlove

tenderlove Sep 12, 2012

Member

We don't need to monkey patch MT to fix this. Just add the backtrace cleaner method to the MT/Spec subclass (AS::TestCase).

Member

tenderlove commented Sep 12, 2012

We don't need to monkey patch MT to fix this. Just add the backtrace cleaner method to the MT/Spec subclass (AS::TestCase).

@frodsan

This comment has been minimized.

Show comment
Hide comment
@frodsan

frodsan Sep 20, 2012

Contributor

@tenderlove but the filter_backtrace method is part of the MiniTest module. How would you do it?

Contributor

frodsan commented Sep 20, 2012

@tenderlove but the filter_backtrace method is part of the MiniTest module. How would you do it?

@tenderlove

This comment has been minimized.

Show comment
Hide comment
@tenderlove

tenderlove Sep 23, 2012

Member

Ah, I see. filter_backtrace is a class method (I thought it was an instance method). Let me see what I can do about that.

Member

tenderlove commented Sep 23, 2012

Ah, I see. filter_backtrace is a class method (I thought it was an instance method). Let me see what I can do about that.

@tenderlove

This comment has been minimized.

Show comment
Hide comment
@tenderlove

tenderlove Sep 23, 2012

Member

I've opened a pull request on minitest that would allow us to set our own filter object.

Member

tenderlove commented Sep 23, 2012

I've opened a pull request on minitest that would allow us to set our own filter object.

@arunagw

This comment has been minimized.

Show comment
Hide comment
@arunagw

arunagw Oct 6, 2012

Member

Closing this as it's fixed. #7861

Member

arunagw commented Oct 6, 2012

Closing this as it's fixed. #7861

@arunagw arunagw closed this Oct 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment