New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 1.9.2 minitest is not applying our backtrace cleaner in tests #1575
Comments
I see this even if turn is on. See https://github.com/metaskills/mini_backtrace for a workaround and possible fix. |
This is pulled & fixed, could someone close it? ed1fb7a |
@tass i can't see this in code. :( |
cc @arunagw |
As was just pointed out to me, this hasn't landed in master yet. My bad! |
Yeah. Actually This is not applied yet :-( |
@arunagw any news? :) |
I will try to work this week. Otherwise I will remove my name from assignee so anybody can pick this up :-) |
We don't need to monkey patch MT to fix this. Just add the backtrace cleaner method to the MT/Spec subclass (AS::TestCase). |
@tenderlove but the |
Ah, I see. |
I've opened a pull request on minitest that would allow us to set our own filter object. |
Closing this as it's fixed. #7861 |
When Turn is off, you get the full backtrace when a test fails. It's not scrubbed with the backtrace cleaner.
The text was updated successfully, but these errors were encountered: