Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 1.9.2 minitest is not applying our backtrace cleaner in tests #1575

Closed
dhh opened this issue Jun 8, 2011 · 14 comments · Fixed by #7861
Closed

Ruby 1.9.2 minitest is not applying our backtrace cleaner in tests #1575

dhh opened this issue Jun 8, 2011 · 14 comments · Fixed by #7861
Assignees

Comments

@dhh
Copy link
Member

dhh commented Jun 8, 2011

When Turn is off, you get the full backtrace when a test fails. It's not scrubbed with the backtrace cleaner.

@faisal
Copy link

faisal commented Jul 24, 2011

I see this even if turn is on. See https://github.com/metaskills/mini_backtrace for a workaround and possible fix.

@reactormonk
Copy link

This is pulled & fixed, could someone close it? ed1fb7a

@arunagw
Copy link
Member

arunagw commented Mar 6, 2012

@tass i can't see this in code. :(

@rafaelfranca
Copy link
Member

cc @arunagw

@ghost ghost assigned arunagw Apr 28, 2012
@steveklabnik
Copy link
Member

@tass I'll gladly close it, since ed1fb7a seems to take care of things.

@steveklabnik
Copy link
Member

As was just pointed out to me, this hasn't landed in master yet. My bad!

@arunagw
Copy link
Member

arunagw commented Apr 29, 2012

Yeah. Actually This is not applied yet :-(

@frodsan
Copy link
Contributor

frodsan commented Sep 12, 2012

@arunagw any news? :)

@arunagw
Copy link
Member

arunagw commented Sep 12, 2012

I will try to work this week. Otherwise I will remove my name from assignee so anybody can pick this up :-)

@tenderlove
Copy link
Member

We don't need to monkey patch MT to fix this. Just add the backtrace cleaner method to the MT/Spec subclass (AS::TestCase).

@frodsan
Copy link
Contributor

frodsan commented Sep 20, 2012

@tenderlove but the filter_backtrace method is part of the MiniTest module. How would you do it?

@tenderlove
Copy link
Member

Ah, I see. filter_backtrace is a class method (I thought it was an instance method). Let me see what I can do about that.

@tenderlove
Copy link
Member

I've opened a pull request on minitest that would allow us to set our own filter object.

@arunagw
Copy link
Member

arunagw commented Oct 6, 2012

Closing this as it's fixed. #7861

@arunagw arunagw closed this as completed Oct 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants