GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When Turn is off, you get the full backtrace when a test fails. It's not scrubbed with the backtrace cleaner.
I see this even if turn is on. See https://github.com/metaskills/mini_backtrace for a workaround and possible fix.
Ruby 1.9.2 minitest is now applying our backtrace cleaner in tests fixes
This is pulled & fixed, could someone close it? ed1fb7a
@tass i can't see this in code. :(
@tass I'll gladly close it, since ed1fb7a seems to take care of things.
As was just pointed out to me, this hasn't landed in master yet. My bad!
Yeah. Actually This is not applied yet :-(
@arunagw any news? :)
I will try to work this week. Otherwise I will remove my name from assignee so anybody can pick this up :-)
We don't need to monkey patch MT to fix this. Just add the backtrace cleaner method to the MT/Spec subclass (AS::TestCase).
@tenderlove but the filter_backtrace method is part of the MiniTest module. How would you do it?
Ah, I see. filter_backtrace is a class method (I thought it was an instance method). Let me see what I can do about that.
I've opened a pull request on minitest that would allow us to set our own filter object.
Closing this as it's fixed. #7861