Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arel version dependency breaks gems #16063

Closed
steveklabnik opened this issue Jul 5, 2014 · 7 comments
Closed

Arel version dependency breaks gems #16063

steveklabnik opened this issue Jul 5, 2014 · 7 comments

Comments

@steveklabnik
Copy link
Member

In f200383, arel's version got bumped. But since 6.0 hasn't been released yet, any gem that tries to integration test against Rails master straight-up fails:

https://travis-ci.org/steveklabnik/active_model_serializers/jobs/29204778

https://travis-ci.org/drapergem/draper/jobs/29070352

etc.

This means that getting early bug reports about stuff in master that breaks gems that depend on Rails won't happen.

@seuros
Copy link
Member

seuros commented Jul 5, 2014

If you trying against rails master, add the arel from master too. Something like i did here.

@zzak
Copy link
Member

zzak commented Jul 5, 2014

What @seuros said, if you want to test rails master make sure you include arel master too, just like we are doing.

@zzak zzak closed this as completed Jul 5, 2014
@steveklabnik
Copy link
Member Author

This is a transitive dependency though. Awkward.

steveklabnik added a commit to steveklabnik/active_model_serializers that referenced this issue Jul 5, 2014
@matthewd
Copy link
Member

matthewd commented Jul 5, 2014

Awkward indeed... but I think it's really in bundler's problem-space: some way for us to say "hey, if you're pulling us from git, and you don't have a better idea, you might want to try as a source for arel".

The problems (and potential security implications) of such a scheme are multitudinous, and likely why it's not supported.

/ping @indirect in case he has any brilliant suggestions ☺️

@indirect
Copy link
Member

indirect commented Jul 6, 2014

Some options: combine repos, modify the bootstrap script to check out arel, create a separate Gemfile for rails master, release prerelease gems every time there's a breaking dependency change, put it in the readme in big letters.

There's no magical automatic solution to breaking dependency changes, but you can solve them by solving them. :P

On Sat, Jul 5, 2014 at 10:29 AM, Matthew Draper notifications@github.com
wrote:

Awkward indeed... but I think it's really in bundler's problem-space: some way for us to say "hey, if you're pulling us from git, and you don't have a better idea, you might want to try as a source for arel".
The problems (and potential security implications) of such a scheme are multitudinous, and likely why it's not supported.

/ping @indirect in case he has any brilliant suggestions ☺️

Reply to this email directly or view it on GitHub:
#16063 (comment)

@sgrif
Copy link
Contributor

sgrif commented Jul 6, 2014

you can solve them by solving them.

http://gifrific.com/wp-content/uploads/2012/04/mind-blown-classic.gif

@indirect
Copy link
Member

indirect commented Jul 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants