Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

render :inline broken in 3.0.9.rc3 #1633

Closed
tmilker opened this Issue Jun 10, 2011 · 1 comment

Comments

Projects
None yet
3 participants

tmilker commented Jun 10, 2011

The SafeBuffer fixes have broken render :inline in rails 3.0.8 and 3.0.9.rc3. I did not try 3.1.

render :inline => raw @content
ActionView::Template::Error (Cannot modify SafeBuffer in place):
  app/views/pages/show.html.erb:1:in `_app_views_pages_show_html_erb___400914214750921592_17192981340__1418047418121329627'


activesupport (3.0.9.rc3) lib/active_support/core_ext/string/output_safety.rb:123:in `sub!'
actionpack (3.0.9.rc3) lib/action_view/template.rb:198:in `compile'
actionpack (3.0.9.rc3) lib/action_view/template.rb:134:in `block in render'
activesupport (3.0.9.rc3) lib/active_support/notifications.rb:54:in `instrument'
actionpack (3.0.9.rc3) lib/action_view/template.rb:127:in `render'
actionpack (3.0.9.rc3) lib/action_view/render/rendering.rb:59:in `block in _render_template'
activesupport (3.0.9.rc3) lib/active_support/notifications.rb:52:in `block in instrument'
activesupport (3.0.9.rc3) lib/active_support/notifications/instrumenter.rb:21:in `instrument'
activesupport (3.0.9.rc3) lib/active_support/notifications.rb:52:in `instrument'
actionpack (3.0.9.rc3) lib/action_view/render/rendering.rb:56:in `_render_template'
actionpack (3.0.9.rc3) lib/action_view/render/rendering.rb:26:in `render'

Please see the following gist for the full trace

https://gist.github.com/1018921

@ghost ghost assigned sikachu Jun 10, 2011

sikachu added a commit to sikachu/rails that referenced this issue Jun 10, 2011

Make sure that we don't perform in-place mutation on SafeBuffer string
This will make sure `render :inline` is working.

Closes #1633

sikachu added a commit to sikachu/rails that referenced this issue Jun 10, 2011

Make sure that we don't perform in-place mutation on SafeBuffer string
This will make sure `render :inline` is working.

Closes #1633

sikachu added a commit to sikachu/rails that referenced this issue Jun 10, 2011

Make sure that we don't perform in-place mutation on SafeBuffer string
This will make sure `render :inline` is working.

Closes #1633

@sikachu sikachu closed this in 104e200 Jun 10, 2011

Owner

spastorino commented Jun 11, 2011

This doesn't make any sense.
@tmilker you are using render :inline in a wrong way, there's no need for raw there.
Just render :inline => @content do the same thing.

jake3030 pushed a commit to jake3030/rails that referenced this issue Jun 28, 2011

Fix HasManyAssociation#create ignoring the :primary_key option [#1633
…state:resolved]

Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com>

jake3030 pushed a commit to jake3030/rails that referenced this issue Jun 28, 2011

Fix HasManyAssociation#create ignoring the :primary_key option [#1633
…state:resolved]

Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment