send_file should be able to guess default mime type from filename #1847

Closed
esad opened this Issue Jun 24, 2011 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

esad commented Jun 24, 2011

Currently, send_file will use application/octet-stream as mime type per default although a correct mime type can be inferred from the file extension most of the time

Contributor

anildigital commented Jun 27, 2011

Patch is welcome.

Contributor

esad commented Jun 28, 2011

I just made a pull request (#1875). Are pull requests preferred, or should I attach a patch?

@josevalim josevalim added a commit that referenced this issue Jun 28, 2011

@josevalim josevalim Merge pull request #1875 from esad/master
Fixed issue #1847
4f372cf

josevalim closed this Jun 28, 2011

@jake3030 jake3030 pushed a commit to jake3030/rails that referenced this issue Jun 28, 2011

@guillermo @dhh guillermo + dhh Deprecated warnings for :skip_last_command and :connector of to_sente…
…nce [#1847 state:committed]

Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
ff1afbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment