more cowbell #2

Closed
webiest opened this Issue Apr 17, 2009 · 5 comments

Comments

Projects
None yet
5 participants
@ghost

ghost commented Apr 17, 2009

No description provided.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 17, 2009

gold plated diapers

ghost commented Apr 17, 2009

gold plated diapers

@mischa

This comment has been minimized.

Show comment
Hide comment

mischa commented Apr 17, 2009

+1

@samoli

This comment has been minimized.

Show comment
Hide comment
@samoli

samoli Apr 17, 2009

Contributor

+1

Contributor

samoli commented Apr 17, 2009

+1

@qrush

This comment has been minimized.

Show comment
Hide comment
@qrush

qrush Apr 17, 2009

Contributor

-1

Contributor

qrush commented Apr 17, 2009

-1

@rabble

This comment has been minimized.

Show comment
Hide comment

rabble commented Apr 17, 2009

+1

tomstuart pushed a commit to econsultancy/rails that referenced this issue May 17, 2011

bfolkens added a commit to bfolkens/rails that referenced this issue Jul 17, 2011

ghost pushed a commit to Mochaleaf/rails that referenced this issue Jul 23, 2011

rails#759 -
There are two issues here:

#1) ActiveSupport::Date current method has a misleading conditional. Time.zone is always returned because config.time_zone is set by default on a project.

#2) ActiveSupport::Date does not override the Date.today method. This means that the core ruby library's .today method is called which may be based off of a different time zone than what's set in config.time_zone.

Submitting a pull request.

ghost pushed a commit to Mochaleaf/rails that referenced this issue Aug 4, 2011

Fixing bugs in ActiveSupport::Date. Fixes #759.
There are two issues here:

#1) ActiveSupport::Date current method has a misleading conditional. Time.zone is always returned because config.time_zone is set by default on a project.

#2) ActiveSupport::Date does not override the Date.today method. This means that the core ruby library's .today method is called which may be based off of a different time zone than what's set in config.time_zone.

derekkraan added a commit to Springest/rails that referenced this issue Dec 4, 2012

joergschray added a commit to tandem-softworks/rails that referenced this issue Apr 27, 2013

Issue #1: :before_add callback is called when nested attributes assig…
…nment assigns to existing record if the association is not yet loaded

Issue #2: Nested Attributes assignment does not affect the record in the association target when callback triggers loading of the association

Complete rewrite of tests

Empact added a commit to Empact/rails that referenced this issue Aug 12, 2013

Fix interactions between :before_add callbacks and nested attributes …
…assignment

Issue #1: :before_add callback is called when nested attributes assignment assigns to existing record if the association is not yet loaded
Issue #2: Nested Attributes assignment does not affect the record in the association target when callback triggers loading of the association

jrafanie pushed a commit to jrafanie/rails that referenced this issue Aug 8, 2014

Merge pull request #2 from kbrock/quick_saves
Not treating serialized field changes differently than other fields

rafaelfranca pushed a commit that referenced this issue Oct 15, 2014

Remove duplicate stringify_keys in text_field_tag
All the methods that invoke `text_field_tag` (such as `hidden_field_tag`)
and all the methods that invoke `number_field_tag` (that is `range_field_tag`)
do not need to call `stringify_keys` on their `options` parameter since the
`text_field_tag` method [is already doing it internally](https://github.com/claudiob/rails/blob/4159134524f4c78d008eef9d9a17f73a3172dcc8/actionview/lib/action_view/helpers/form_tag_helper.rb#L182):

```ruby
def text_field_tag(name, value = nil, options = {})
  tag :input, { "type" => "text", "name" => name, "id" => sanitize_to_id(name), "value" => value }.update(options.stringify_keys)
end
```

and `number_field_tag` is [already doing it internally](https://github.com/claudiob/rails/blob/e3207bdbba55f3806441f22b175557579bc0b051/actionview/lib/action_view/helpers/form_tag_helper.rb#L780) as well:

```ruby
def number_field_tag(name, value = nil, options = {})
  options = options.stringify_keys
  ...
end

[Note #1: My code uses `merge` to respect the existing behavior of
duplicating the `options` hash before updating its keys, see #17096 (comment)]

[Note #2: My code uses symbols instead of strings (e.g.: `:hidden`) to look
forward to future version of Ruby/Raiks (GC symbols); the result of the method,
however, is the same, because the symbols are stringified inside `text_field_tag`]

[Note #3: I had previously created a similar PR #17096 but decided to
split it into multiple PRs given the feedback received in the comments]

sachin004 added a commit to sachin004/rails that referenced this issue Dec 13, 2014

Remove duplicate stringify_keys in text_field_tag
All the methods that invoke `text_field_tag` (such as `hidden_field_tag`)
and all the methods that invoke `number_field_tag` (that is `range_field_tag`)
do not need to call `stringify_keys` on their `options` parameter since the
`text_field_tag` method [is already doing it internally](https://github.com/claudiob/rails/blob/4159134524f4c78d008eef9d9a17f73a3172dcc8/actionview/lib/action_view/helpers/form_tag_helper.rb#L182):

```ruby
def text_field_tag(name, value = nil, options = {})
  tag :input, { "type" => "text", "name" => name, "id" => sanitize_to_id(name), "value" => value }.update(options.stringify_keys)
end
```

and `number_field_tag` is [already doing it internally](https://github.com/claudiob/rails/blob/e3207bdbba55f3806441f22b175557579bc0b051/actionview/lib/action_view/helpers/form_tag_helper.rb#L780) as well:

```ruby
def number_field_tag(name, value = nil, options = {})
  options = options.stringify_keys
  ...
end

[Note #1: My code uses `merge` to respect the existing behavior of
duplicating the `options` hash before updating its keys, see rails#17096 (comment)]

[Note #2: My code uses symbols instead of strings (e.g.: `:hidden`) to look
forward to future version of Ruby/Raiks (GC symbols); the result of the method,
however, is the same, because the symbols are stringified inside `text_field_tag`]

[Note #3: I had previously created a similar PR #17096 but decided to
split it into multiple PRs given the feedback received in the comments]

BMorearty pushed a commit to BMorearty/rails that referenced this issue Jan 31, 2015

keepcosmos pushed a commit to keepcosmos/rails that referenced this issue Jul 12, 2015

Merge pull request #2 from luciuschoi/guides-ko
Active Job Basics 번역 시작함.

tijmenb added a commit to tijmenb/rails that referenced this issue Nov 3, 2015

Add text template for source code
When a request is made with AJAX and an error occurs, Rails will render
a text-template for the exception instead of the HTML error page
(#11960).

The `.text.erb` variant of the `_source` template is currently missing,
causing HTML to be rendered in the response. This commit adds the text
template.

Related to #14745.

Before:

```
~/testing-exceptions  ᐅ curl 'http://localhost:3000/' -H
'X-Requested-With: XMLHttpRequest'
RuntimeError in PostsController#index

    <div class="source " id="frame-source-0">
      <div class="info">
        Extracted source (around line <strong>#3</strong>):
      </div>
      <div class="data">
        <table cellpadding="0" cellspacing="0" class="lines">
          <tr>
```

After:

```
~/testing-exceptions  ᐅ curl 'http://localhost:3000/' -H
'X-Requested-With: XMLHttpRequest'
RuntimeError in PostsController#index

Extracted source (around line #3):

#1 class PostsController < ApplicationController
#2   def index
*3     raise
#4   end
#5 end
```

dhh pushed a commit to dhh/rails that referenced this issue Dec 14, 2015

yahonda added a commit to yahonda/rails that referenced this issue Jun 13, 2016

yahonda added a commit to yahonda/rails that referenced this issue Jun 13, 2016

mwatt pushed a commit to mwatt/rails that referenced this issue Jul 2, 2016

Merge pull request #2 from thiagoaugusto/thiagoaugusto-update-routing…
…-test

Update routing_test.rb 'and' operator

hisas pushed a commit to hisas/rails that referenced this issue May 9, 2017

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment