Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused deprecation notice #22502

Merged
merged 1 commit into from Dec 11, 2015
Merged

Remove unused deprecation notice #22502

merged 1 commit into from Dec 11, 2015

Conversation

maclover7
Copy link
Contributor

The rake db:test:* tasks were deprecated in #13528, but were
undeprecated and added back in via #17739.

@maclover7
Remove unused deprecation notice
c199b70 
The `rake db:test:*` tasks were deprecated in rails#13528, but were
undeprecated and added back in via rails#17739.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@maclover7
Copy link
Contributor Author

Never mind... turns out some of the tasks still use deprecated task. Since we're hitting 5.0.0 soon, do we want to remove the deprecated tasks? The deprecation was added back in 4.1.x.

r? @senny since he was the last to touch this area.

@rails-bot rails-bot assigned senny and unassigned pixeltrix Dec 5, 2015
@arthurnn
Copy link
Member

arthurnn commented Dec 5, 2015

as far as I can tell, this deprecation is not even true anymore. I remember seen somewhere that the auto update of the test database didnt work for some reason, which I dont remember what was it.
@rafaelfranca or @senny will know better.

@senny
Copy link
Member

senny commented Dec 7, 2015

As things stand now, we can not deprecate or remove db:test:prepare it's still necessary and advised for some workflows. Maybe I'll get around to changing that before Rails 5. In that case I'll add the deprecation myself.

Regarding the other, still deprecated, tasks. We can remove them.

arthurnn pushed a commit that referenced this pull request Dec 11, 2015
Merge pull request #22502 from maclover7/remove-deprecation-notice
c2e70ca 
Remove unused deprecation notice
@arthurnn arthurnn merged commit c2e70ca into rails:master Dec 11, 2015
@arthurnn
Copy link
Member

thanks

@arthurnn
Copy link
Member

I reverted this, as seems like there is still some tasks using that. a42770c

see the broken build https://travis-ci.org/rails/rails/jobs/96307256

arthurnn added a commit that referenced this pull request Dec 11, 2015
@arthurnn
Revert "Merge pull request #22502 from maclover7/remove-deprecation-n…
a42770c 
…otice"

This reverts commit c2e70ca, reversing
changes made to b0e5fc2.

this broke the build
@maclover7 maclover7 deleted the remove-deprecation-notice branch December 22, 2015 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@senny senny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maclover7 @rails-bot @arthurnn @senny @pixeltrix