default Gemfile should not require gems not required by the rails gems #2401

Closed
darix opened this Issue Aug 2, 2011 · 1 comment

Comments

Projects
None yet
2 participants

darix commented Aug 2, 2011

somewhat related to issue #2132

the default gem file for a new rails app (even called with -J -S) still has the following block in the gem file

group :assets do
  gem 'sass-rails', "~> 3.1.0.rc"
  gem 'coffee-rails', "~> 3.1.0.rc"
  gem 'uglifier'
end

Those are gems not required by the rails gem packages. An user who wishes to use the system installed gems (and only those) would now get additional gems pulled in. This gets especially annoying with the default to run bundler after creating a new app. A bundler run at that stage should be a noop. but with the current settings it isnt.

proposed solution

  1. comment out the asset block in the default config.
    or
  2. make the rails gems require those dependencies.

personally i would prefer the first solution and a default to skip bundler.

Member

josevalim commented Aug 3, 2011

The gems in the Gemfile does not need to necessarily be in the rails gem. For example, sqlite3 was never a rails gem dependency but always there in the Gemfile.

josevalim closed this Aug 3, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment