Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ActiveRecord::Aggregations#composed_of splats Hash values instead of assigning Hash #25978
Steps to reproduce
See the repro app here: https://github.com/olivierlacan/rails-4-2-composed-of-hash-values-splat
This "bug" (debatable) was introduced by: 36e9be8
It wasn't resolved by 0d5d859 which resolved a different issue caused by the above commit.
I promise I really like @sgrif, it's just very surprising behavior and I don't think
I would expect composed_of's dynamic writer to assign my damn Hash instance to my damn text column.
ArgumentError because composed_of's
Rails version: 4.2.7
Ruby version: 2.3.1
I feel like I'm being devil's advocate here. I will definitely spray composed_of with fire in our codebase and replace it with
I wouldn't cry too much if you classified this as a "won't fix", it's just a hurdle to the upgrade path I really didn't expect.