Skip to content

Conversation

@yhirano55
Copy link
Contributor

Summary

  • Update links to use https instead of http in activesupport.
  • All changes are only in comment blocks. So I've skipped CI.

@rails-bot
Copy link

r? @kaspth

(@rails-bot has picked a reviewer for you, use r? to override)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

www. is unneeded.

% curl -v -I https://www.unicode.org/reports/tr15
*   Trying 216.97.88.9...
* Connected to www.unicode.org (216.97.88.9) port 443 (#0)
* TLS 1.2 connection using TLS_DHE_RSA_WITH_AES_256_GCM_SHA384
* Server certificate: unicode.org
* Server certificate: COMODO RSA Organization Validation Secure Server CA
* Server certificate: COMODO RSA Certification Authority
* Server certificate: AddTrust External CA Root
> HEAD /reports/tr15 HTTP/1.1
> Host: www.unicode.org
> User-Agent: curl/7.43.0
> Accept: */*
> 
< HTTP/1.1 301 Moved Permanently
HTTP/1.1 301 Moved Permanently
< Date: Tue, 22 Aug 2017 02:07:00 GMT
Date: Tue, 22 Aug 2017 02:07:00 GMT
< Server: Apache
Server: Apache
< Location: https://unicode.org/reports/tr15/
Location: https://unicode.org/reports/tr15/
< Vary: Accept-Encoding
Vary: Accept-Encoding
< Content-Type: text/html; charset=iso-8859-1
Content-Type: text/html; charset=iso-8859-1

< 
* Connection #0 to host www.unicode.org left intact

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you confirmed the page? https://www.unicode.org/reports/tr15/
Looks like that the original link is the right page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamipo Thanks for you comments. I'll check all links again, and fix it soon.

@yhirano55 yhirano55 force-pushed the use_https_instead_of_http_in_activesupport branch from fabb8f3 to d8b3afc Compare August 22, 2017 02:15
@yhirano55 yhirano55 force-pushed the use_https_instead_of_http_in_activesupport branch from d8b3afc to b279375 Compare August 22, 2017 02:32
@yhirano55
Copy link
Contributor Author

@kamipo I've checked all links and fixed them.

  • Add trailing slash to https://www.limited-entropy.com/padding-oracle-attacks/
  • Remove trailing slash from https://memcached.org
  • https://www.ietf.org/rfc/rfc4122.txt doesn't have any problems.
  • It seems that contents of www.unicode.org is different from between http and https. So I've restored them.

@kamipo kamipo merged commit 3fdfe21 into rails:master Aug 22, 2017
@yhirano55 yhirano55 deleted the use_https_instead_of_http_in_activesupport branch August 22, 2017 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants