Regex with a period route fails

[tc]

I have a route file where a regex matcher works in a resource scope but not in the match method:

routes.rb:

  regex = /[\w\d\s!\.]+?/
  resources :pages, :id => regex do
    member do
      get 'embed'
    end
  end
  match "/embed/:id" => "pages#embed", :id => regex

pages_controller.rb:

  def embed
    id = params[:id]
    render :text => "id is #{id}"
  end

This route works:
http://localhost:3000/pages/Edwin.Lee/embed
id is Edwin.Lee

This one fails:
http://localhost:3000/embed/Edwin.Lee
id is Edwin

[alindeman]

What happens if your regex is greedy? .. e.g., /[\w\d\s!\.]+/

[alindeman]

What happens if your regex is greedy? .. e.g., /[\w\d\s!\.]+/

[tc]

using the greedy regex works as a workaround, but it's still odd there's a different behavior when using the same regex with resources/match.

[tc]

using the greedy regex works as a workaround, but it's still odd there's a different behavior when using the same regex with resources/match.

[alindeman]

I have yet to verify myself, but I'm betting this has something to do with Rails automatically expecting a .format at the end of routes. If your regex doesn't capture it, it'll be picked up as a .format.

To verify, check the value of params[:format] in your controller when the non-greedy regex is used.

[alindeman]

I have yet to verify myself, but I'm betting this has something to do with Rails automatically expecting a .format at the end of routes. If your regex doesn't capture it, it'll be picked up as a .format.

To verify, check the value of params[:format] in your controller when the non-greedy regex is used.

[tc]

That makes sense, but what doesn't is the different behavior of match and resource methods. Shouldn't the params capturing behave the same way?

[tc]

That makes sense, but what doesn't is the different behavior of match and resource methods. Shouldn't the params capturing behave the same way?

[alindeman]

.format is only at the very end.

[alindeman]

.format is only at the very end.

[isaacsanders]

@tc Is this still an issue?

[isaacsanders]

@tc Is this still an issue?

[tc]

@alindeman suggested a workaround by using a greedy regex expression.

  regex = /[\w\d\s!\.]+?/
  greedy_regex = /[\w\d\s!\.]+/

Using the non-greedy regex on http://localhost:3000/embed/Edwin.Lee will capture Edwin(instead of Edwin.Lee) as params[:id]

This can be closed if this is the intended behavior.

[tc]

@alindeman suggested a workaround by using a greedy regex expression.

  regex = /[\w\d\s!\.]+?/
  greedy_regex = /[\w\d\s!\.]+/

Using the non-greedy regex on http://localhost:3000/embed/Edwin.Lee will capture Edwin(instead of Edwin.Lee) as params[:id]

This can be closed if this is the intended behavior.

[kytrinyx]

@steveklabnik It looks like this issue can be closed.

[kytrinyx]

@steveklabnik It looks like this issue can be closed.