You can clone with
No one assigned
The code at this line is never reached. Is this a bug? Should the hash be returned sometimes?
I've been chasing history.
I think that the below commit is the origin.
I think that it is a mistake :-)
do you remember it ?
I think that this is a bug. And we have two fix way.
1: Return hash. It seems that original source's behavior return hash.
2: Raise an error. Now behavior raise an error.
I think that now behavior is proper (therefore we should remove only the hash).
What do you think ?
@kennyj, I believe that the current behavior is correct, too: the hash itself does not makes much sense for me, and the parsing error should clearly not just be forwarded to action body, as the latter does not expects it and this behavior is not documented anywhere I know.
The next commit is my opinion.
1: remove unreachable code.
2: re-raise original exception.
Just FYI: raise without arguments is just the same as raise e (in this context) or raise $! (generally). It's fine this way, through.
@whitequark, I didn't know it. Thanks!
I'll change commit message, and send pull request.
When chasing history, I feel like a historian.
Merge pull request #3735 from kennyj/fix_3728
Fix #3728 Remove unreachable code, and add additional testcases.