Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

ActiveSupport::Benchmarkable#silence is not threadsafe! #4060

Closed
ketan opened this Issue · 2 comments

4 participants

@ketan

When two threads go through this method, it's possible to permanently set the log level to ERROR at the end of execution of both blocks. Here's a testcase to reproduce this.

I should mention that this is reproducible with rails 3.1.3 and 3.2RC1.

@tenderlove
Owner
@isaacsanders

Any thoughts on this?

@steveklabnik steveklabnik closed this issue from a commit
@steveklabnik steveklabnik Deprecate ActiveSupport::Benchmarkable#silence.
Due to its lack of thread safety, we're deprecating this, and it
will be removed in Rails 4.1.

Fixes #4060.
ed2fea9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.