Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment class for controller caching #4211

Closed
gazay opened this issue Dec 28, 2011 · 4 comments
Closed

Fragment class for controller caching #4211

gazay opened this issue Dec 28, 2011 · 4 comments

Comments

@gazay
Copy link
Contributor

gazay commented Dec 28, 2011

Hello! I thinking about creating a class for working with cache fragments

71c9337#L5R40

It's still relevant?

I want to create something like ActionController::Caching::Fragment class with methods read, write and expire and replace ActionController::Caching::Fragments#read_fragment and write_fragment with find_fragment and create_fragment.

There are my sketches: https://gist.github.com/1526231

What do you think? And should we keep objects of Fragment class in controller instance?

@ahawkins
Copy link

@gazay what do you actually want to do? Seems this isn't an issue with rails, but rather something you want to do inside your application.

@rafaelfranca
Copy link
Member

This is a feature request. He want to to add an object to deal with fragment cache as described in a TODO by @wycats. I don't know if this is still relevant. Could you take a look on this @wycats, @josevalim?

@wycats
Copy link
Member

wycats commented May 7, 2012

My recollection is that at the time, I thought that the logic could be better encapsulated by breaking it out into a separate class.

@steveklabnik
Copy link
Member

Feature request with no discussion in the last 4 months, so I'm closing. @gazay if you'd like to create a class, feel free to do the refactoring and submit a PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants