Fix failing test in xml_mini_test.rb #450

Closed
mikegehard opened this Issue May 7, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@mikegehard
Contributor

mikegehard commented May 7, 2011

This failing test is a result of some duplicate test names and the fact that some of the tests for XmlMini weren't getting run.

See #449 for a bit more information.

The regex that is handling the code for the failing test is above my head right now.

Will take a look when I have more time unless someone gets to it before me.

@spastorino spastorino closed this May 7, 2011

@spastorino

This comment has been minimized.

Show comment Hide comment
@spastorino

spastorino May 7, 2011

Owner

I've pushed it

Owner

spastorino commented May 7, 2011

I've pushed it

hisas pushed a commit to hisas/rails that referenced this issue May 9, 2017

Improve handling of backslashes in quoted strings. [Fixes #450]
The relevant part of RFC-822 says that '\' '"' and "\r" should be
escaped in quoted strings.

I have added escaping for '\', but not for '\r' as we already use
quoted-printable form for those (and if we allow raw newlines in headers
we have to be much more careful to avoid header-injection).

I've also fixed unquote() to remove backslash-escaping from the string
as RFC-822 suggests.

hisas pushed a commit to hisas/rails that referenced this issue May 9, 2017

Merge pull request #506 from ConradIrwin/450-backslash
Improve handling of backslashes in quoted strings. [Fixes #450]

matthewd pushed a commit that referenced this issue Apr 24, 2018

Merge pull request #450 from roooodcastro/issue-438
Use Arel::Nodes::BindParam in Oracle visitor for queries using both LIMIT and OFFSET
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment