Skip to content

optional start_day argument for Time#all_week #4883

Closed
ghost opened this Issue Feb 5, 2012 · 4 comments

2 participants

@ghost
ghost commented Feb 5, 2012

I've noticed that Rails 3.2 adds optional start_day argument to beginning_of_week and end_of_week methods.

It could be nice to have the same argument available for Time#all_week method.

@kennyj kennyj added a commit to kennyj/rails that referenced this issue Feb 5, 2012
@kennyj kennyj GH #4883. Optional start_day argument for Time#all_week 1d3ac98
@kennyj
kennyj commented Feb 5, 2012

@cveneziani-silicon

Agree. I implemented your opinion. Please review the above commit :-)

@spastorino
Ruby on Rails member

@kennyj can you provide a PR please?

@kennyj
kennyj commented Feb 5, 2012

@spastorino Of course :)

#4890

I send PR to 3-2-stable.

@kennyj kennyj added a commit to kennyj/rails that referenced this issue Feb 5, 2012
@kennyj kennyj GH #4883. Optional start_day argument for Time#all_week b037401
@kennyj kennyj closed this in 9abdabf Feb 5, 2012
@ghost
ghost commented Feb 6, 2012

Thanks @kennyj and @spastorino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.