Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

optional start_day argument for Time#all_week #4883

Closed
ghost opened this Issue · 4 comments

2 participants

@ghost

I've noticed that Rails 3.2 adds optional start_day argument to beginning_of_week and end_of_week methods.

It could be nice to have the same argument available for Time#all_week method.

@kennyj
Collaborator

@cveneziani-silicon

Agree. I implemented your opinion. Please review the above commit :-)

@spastorino
Owner

@kennyj can you provide a PR please?

@kennyj
Collaborator

@spastorino Of course :)

#4890

I send PR to 3-2-stable.

@kennyj kennyj referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@kennyj kennyj referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@kennyj kennyj closed this in 9abdabf
@ghost

Thanks @kennyj and @spastorino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.