Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add bigdecimal to activesupport gemspec #5355

Closed
bkabrda opened this Issue Mar 9, 2012 · 8 comments

Comments

Projects
None yet
4 participants

bkabrda commented Mar 9, 2012

Hi,
due to gemification of the Ruby standard library [1], I think you should include bigdecimal gem in gemspec of activesupport - if new version of bigdecimal is released, you will need to add it there anyway, so that bundler doesn't pick up the bigdecimal that is bundled in the standard Ruby installation. (We are currently doing this unbudling in Fedora very seriously, moving the whole bigdecimal gem under rubygems directory structure, so it doesn't get loaded at all, when you don't add it to activesupport gemspec or Gemfile - which is, I think, not the expected behaviour.)

Thank you!

[1] https://bugs.ruby-lang.org/issues/5481

Contributor

isaacsanders commented May 5, 2012

Is this still an issue?

bkabrda commented May 7, 2012

Yep :)

Contributor

isaacsanders commented May 7, 2012

Contributor

kennyj commented Jun 1, 2012

Did you mean s.add_dependency('bigdecimal', '~> 1.1.0') ?
but we have a problem in jruby.

bkabrda commented Jun 4, 2012

@kennyj Yep, that's exactly what I mean. The JRuby part should probably be discussed with the author of bigdecimal - and it is probably another problem of "fake gems"...

bkabrda commented Jun 14, 2012

I have started the discussion with JRuby authors about this and they took the discussion to the MRI Ruby - see

https://bugs.ruby-lang.org/issues/6590
http://jira.codehaus.org/browse/JRUBY-6704

Contributor

kennyj commented Jun 14, 2012

@bkabrda thank you. Please report us about the discussion.

Member

steveklabnik commented Sep 16, 2012

This is basically a feature request, with no patch. Until we're actually required to rely on the new BigDecimal gem, there's no reason to add a gem dependency. Today, Rubyists have BigDecimal in their standard library, so installing the gem is overkill.

Anyway, I'm closing. If you'd like to try to move this forward anyway, please submit it as a pull request, but I don't think it's a good idea for now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment