GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
due to gemification of the Ruby standard library , I think you should include bigdecimal gem in gemspec of activesupport - if new version of bigdecimal is released, you will need to add it there anyway, so that bundler doesn't pick up the bigdecimal that is bundled in the standard Ruby installation. (We are currently doing this unbudling in Fedora very seriously, moving the whole bigdecimal gem under rubygems directory structure, so it doesn't get loaded at all, when you don't add it to activesupport gemspec or Gemfile - which is, I think, not the expected behaviour.)
Is this still an issue?
Did you mean s.add_dependency('bigdecimal', '~> 1.1.0') ?
but we have a problem in jruby.
s.add_dependency('bigdecimal', '~> 1.1.0')
@kennyj Yep, that's exactly what I mean. The JRuby part should probably be discussed with the author of bigdecimal - and it is probably another problem of "fake gems"...
I have started the discussion with JRuby authors about this and they took the discussion to the MRI Ruby - see
@bkabrda thank you. Please report us about the discussion.
This is basically a feature request, with no patch. Until we're actually required to rely on the new BigDecimal gem, there's no reason to add a gem dependency. Today, Rubyists have BigDecimal in their standard library, so installing the gem is overkill.
Anyway, I'm closing. If you'd like to try to move this forward anyway, please submit it as a pull request, but I don't think it's a good idea for now. Thanks.