ActiveRecord Hstore bug: can't update a key in the hash

[joevandyk]

joevandyk@f2318b2 shows a failing test.

  def test_updating_key                                                                             
    x = Hstore.create! :tags => { "key1" => "old value 1", "key2" => "old value 2" }                
    x.reload                                                                                        
    assert_equal "old value 1", x.tags["key1"]                                                      

    # Nothing gets saved/updated here.
    x.tags["key1"] = "new"                                                                          
    x.save!                                                                                         

    assert_equal "new", x.reload.tags["key1"]                                                       
    assert_equal "old value 2",   x.reload.tags["key2"]                                             
  end

  1) Failure:
test_updating_key(PostgresqlHstoreTest) [cases/adapters/postgresql/hstore_test.rb:55]:
Expected: "new"
  Actual: "old value 1"

[kennyj]

I can reproduce this issue.
It seems that any query weren't executed when executing save!
I guess:
x.tags method returns a Hash object, and we can't track dirty flag.

[gertig]

I can also reproduce this issue.

[al2o3cr]

A quick workaround would be to call (in your example) x.tags_will_change! before setting the new value.

Historically, this has always been a problem with serialize columns, and AR's approach in that case is to always save serialized columns. HStore columns might need the same treatment.

[tenderlove]

@al2o3cr ya, I've been looking at this. I'd like to treat the hstore columns as serialized columns, but it's going to take a little refactoring.

[parndt]

@tenderlove has there been any refactoring to date that would have helped this?

[neerajsingh0101]

Here is another version and this one does not break the API. It is based on feedback given by @pixeltrix

https://github.com/neerajdotname/rails/compare/6127b

I'll clean up the code a bit , add tests and will delete some code that is not needed regarding hstore etc if there is any interest in moving hstore to be on top of serialization.

[therealjasonkenney]

@neerjdotname Forgive me if this seems naive, but wouldn't it make more sense to specify using hstore in the database.yml (serialize using hstore), what would happen if that model was using sqlite instead?

[neerajsingh0101]

@bloodycelt sqlite does not support hstore. So if you are using sqlite you should not add this line in your model .

serialize :preferences, ActiveRecord::Coders::HstoreColumn.new

[prathamesh-sonpatki]

Bump. Any updates on this?

[robin850]

Isn't it related to #12395 ?