Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

url_for(:controller => 'un_existing', :action => 'show) returns /assets url in 3.2 #6459

Closed
betelgeuse opened this Issue · 3 comments

3 participants

@betelgeuse

In an application without FooController:

url_for(:controller => 'foo', :action => 'show')

In rails 3.1 this raises ActionController::RoutingError

In rails 3.2 you get an url returned:

/assets?action=show&controller=foo

The rails 3.1 result seems the proper one.

@tenderlove Is this a regression in journey?

@drogus drogus was assigned
@drogus
Collaborator

This is rather not regression in journey, as the problem is that assets engine catches this route. If you disable assets you will see RoutingError as in the 3.1 application. I will check why exactly assets catch that route.

@drogus
Collaborator

Just a quick update. I haven't had time to work on this, but my previous comment is stupid :) It is regression in journey, as it's during generation. Sorry for confusion.

@tenderlove
Owner

Should be fixed here.

Thanks for reporting this!

@tenderlove tenderlove closed this
@jperkin jperkin referenced this issue from a commit in joyent/pkgsrc
taca Update ruby-journey to 1.0.4.
Thu Jun 14 14:03:22 2012  Aaron Patterson <aaron@tenderlovemaking.com>

	* lib/journey/formatter.rb: when generating routes, skip route
          literals (routes that do not have replacement values like
          "/:controller") when matching unnamed routes.

            rails/rails#6459

        * test/test_router.rb: corresponding test
5447cb1
@jsonn jsonn referenced this issue from a commit in jsonn/pkgsrc
taca Update ruby-journey to 1.0.4.
Thu Jun 14 14:03:22 2012  Aaron Patterson <aaron@tenderlovemaking.com>

	* lib/journey/formatter.rb: when generating routes, skip route
          literals (routes that do not have replacement values like
          "/:controller") when matching unnamed routes.

            rails/rails#6459

        * test/test_router.rb: corresponding test
34a002b
@ttosch ttosch referenced this issue from a commit
@tenderlove tenderlove adding a test for #6459 b21d851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.