Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url_for(:controller => 'un_existing', :action => 'show) returns /assets url in 3.2 #6459

Closed
betelgeuse opened this issue May 23, 2012 · 3 comments
Closed

url_for(:controller => 'un_existing', :action => 'show) returns /assets url in 3.2 #6459

betelgeuse opened this issue May 23, 2012 · 3 comments
Labels
actionpack regression

Comments

@betelgeuse
Copy link

In an application without FooController:

url_for(:controller => 'foo', :action => 'show')

In rails 3.1 this raises ActionController::RoutingError

In rails 3.2 you get an url returned:

/assets?action=show&controller=foo

The rails 3.1 result seems the proper one.

@tenderlove Is this a regression in journey?
@ghost ghost assigned drogus Jun 2, 2012
@drogus
Copy link
Member

drogus commented Jun 2, 2012

This is rather not regression in journey, as the problem is that assets engine catches this route. If you disable assets you will see RoutingError as in the 3.1 application. I will check why exactly assets catch that route.

@drogus
Copy link
Member

drogus commented Jun 13, 2012

Just a quick update. I haven't had time to work on this, but my previous comment is stupid :) It is regression in journey, as it's during generation. Sorry for confusion.

tenderlove added a commit that referenced this issue Jun 14, 2012
@tenderlove
adding a test for #6459
28e744d
tenderlove added a commit that referenced this issue Jun 14, 2012
@tenderlove
adding a test for #6459
e7d1849
tenderlove added a commit that referenced this issue Jun 14, 2012
@tenderlove
adding a test for #6459
b92860f
@tenderlove
Copy link
Member

Should be fixed here.

Thanks for reporting this!

@isratrade isratrade mentioned this issue Dec 5, 2013
Closed
jperkin pushed a commit to TritonDataCenter/pkgsrc-legacy that referenced this issue Dec 9, 2013
Update ruby-journey to 1.0.4.
5447cb1 
Thu Jun 14 14:03:22 2012  Aaron Patterson <aaron@tenderlovemaking.com>

	* lib/journey/formatter.rb: when generating routes, skip route
          literals (routes that do not have replacement values like
          "/:controller") when matching unnamed routes.

            rails/rails#6459

        * test/test_router.rb: corresponding test
@pixeltrix pixeltrix mentioned this issue Dec 31, 2013
Closed
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Oct 11, 2014
Update ruby-journey to 1.0.4.
34a002b 
Thu Jun 14 14:03:22 2012  Aaron Patterson <aaron@tenderlovemaking.com>

	* lib/journey/formatter.rb: when generating routes, skip route
          literals (routes that do not have replacement values like
          "/:controller") when matching unnamed routes.

            rails/rails#6459

        * test/test_router.rb: corresponding test
@benjaminwood benjaminwood mentioned this issue Sep 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionpack regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tenderlove @drogus @betelgeuse