Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

"rails plugin new name -O" will include sqlite3 as a development dependency #6672

Closed
rosenfeld opened this Issue Jun 7, 2012 · 10 comments

Comments

Projects
None yet
4 participants
Contributor

rosenfeld commented Jun 7, 2012

No description provided.

Owner

rafaelfranca commented Jun 7, 2012

Pull request?

Contributor

rosenfeld commented Jun 7, 2012

No, sorry, just reporting here... Please let me know if creating bugs without pull requests are discouraged and I'll stop sending them.

Owner

rafaelfranca commented Jun 7, 2012

No. It is fine, but doesn't hurt ask for a pull request ;). Thank you for reporting.

Contributor

rosenfeld commented Jun 7, 2012

Ok, sorry if I was rude. It is just that I didn't have a great experience trying to contribute to Rails in the past so it is unlikely that I'll spend a fair amount of time writing patches for Rails. I'd rather invest my time on other projects where it is usually easier for me to contribute...

Member

steveklabnik commented Jun 8, 2012

What can be done to make it easier?

Contributor

rosenfeld commented Jun 8, 2012

The problem is that I spent a considerable amount of time working on some feature and at some point I didn't get any feedback and the feature was closed due to inactivity, so it is more of a social issue than a technical one... The same thing happened to Gitorious a while back and I stopped contributing there too... Sorry, but I'm not too patient with regards to open-source so I prefer to invest my time in projects that respond faster to my pull requests...

Member

drogus commented Jun 8, 2012

@rosenfeld it's best to first ask if a feature is likely to get accepted. Also, pull requests with bug fixes are usually merged faster. New features can add value, but can also add maintenance costs, that's why it's harder to justify some of them.

Contributor

rosenfeld commented Jun 8, 2012

I've asked for about that feature before implementing it. I just got no feedback about how to document it as the documentation would change for lots of helpers and they were not dry. I simply got no replies by that time...

@drogus drogus closed this in 523820f Jun 8, 2012

Member

drogus commented Jun 8, 2012

@rosenfeld I've fixed the issue, thanks for the report!

Contributor

rosenfeld commented Jun 8, 2012

thank you, very much, @drogus! Have a nice weekend! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment