"rails plugin new name -T --full" is broken #6673

Closed
rosenfeld opened this Issue Jun 7, 2012 · 11 comments

Comments

Projects
None yet
3 participants
Contributor

rosenfeld commented Jun 7, 2012

"rake -T" will raise an exception

Owner

rafaelfranca commented Jun 7, 2012

Pull request?

Contributor

rosenfeld commented Jun 7, 2012

It seems this line shouldn't be generated when -T is passed:

load 'rails/tasks/engine.rake'
Contributor

rosenfeld commented Jun 7, 2012

Well, maybe it is not the proper solution but it works for what I want it to do...

Member

arunagw commented Jun 8, 2012

On which version of Rails you are getting this?

Contributor

rosenfeld commented Jun 8, 2012

3.2.5

Member

arunagw commented Jun 8, 2012

I just run at my side. It worked fine for me.

Backtrace please.

Member

arunagw commented Jun 8, 2012

ok rake -T seems broken here. Right ?

Contributor

rosenfeld commented Jun 8, 2012

rake -T --trace

** Invoke load_app (first_time)
** Execute load_app
rake aborted!
cannot load such file -- /home/rodrigo/temp/rails/name/test/dummy/Rakefile
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@rails/gems/railties-3.2.5/lib/rails/tasks/engine.rake:3:in `load'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@rails/gems/railties-3.2.5/lib/rails/tasks/engine.rake:3:in `block (2 levels) in <top (required)>'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/task_manager.rb:207:in `in_namespace'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/dsl_definition.rb:102:in `namespace'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@rails/gems/railties-3.2.5/lib/rails/tasks/engine.rake:2:in `block in <top (required)>'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/task.rb:205:in `call'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/task.rb:205:in `block in execute'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/task.rb:200:in `each'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/task.rb:200:in `execute'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/task.rb:158:in `block in invoke_with_call_chain'
/home/rodrigo/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/monitor.rb:211:in `mon_synchronize'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/task.rb:151:in `invoke_with_call_chain'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/task.rb:144:in `invoke'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:116:in `invoke_task'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@rails/gems/railties-3.2.5/lib/rails/tasks/engine.rake:72:in `<top (required)>'
/home/rodrigo/temp/rails/name/Rakefile:24:in `load'
/home/rodrigo/temp/rails/name/Rakefile:24:in `<top (required)>'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/rake_module.rb:25:in `load_rakefile'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:501:in `raw_load_rakefile'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:82:in `block in load_rakefile'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:81:in `load_rakefile'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:65:in `block in run'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:133:in `standard_exception_handling'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/lib/rake/application.rb:63:in `run'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/gems/rake-0.9.2.2/bin/rake:33:in `<top (required)>'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/bin/rake:19:in `load'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@global/bin/rake:19:in `<main>'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@rails/bin/ruby_noexec_wrapper:14:in `eval'
/home/rodrigo/.rvm/gems/ruby-1.9.3-p194@rails/bin/ruby_noexec_wrapper:14:in `<main>'
Tasks: TOP => load_app

arunagw referenced this issue Jun 8, 2012

Merged

Fix issue 6673 #6678

arunagw closed this in 8b1d475 Jun 8, 2012

Member

arunagw commented Jun 8, 2012

@rosenfeld give a try with 3-2-stable branch. And it should work now.

@arunagw arunagw added a commit to arunagw/rails that referenced this issue Jun 8, 2012

@arunagw arunagw We should not include engine.rake file into rake
if we are passing -T which is skip_test_unit

See issue #6673 for more details.

I saw that we are not creating dummy app even if
we do skip_test_unit.

Fixes #6673
5fa8728
Contributor

rosenfeld commented Jun 8, 2012

Thank you @arunagw, I'll try it later (probably this weekend). Have a nice weekend :)

Contributor

rosenfeld commented Jun 8, 2012

I could finally finish my daily job and tried it on 3-2-stable branch and I can confirm rake is working fine now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment