Rails 3.2.8 breaks several tests we had around ActiveRecord increment / decrement. Specifically we aren't seeing a before_update callback triggered when we call record.increment!(:quantity, 1). The documentation says that it skips validation but says nothing about callbacks in general.
/cc @jonleighton @tenderlove
Sorry for not trying out rc2. :-(
@steveklabnik this is easy to fix. Just revert this commit b081f6b.
But we need to know if is expected to increment and related method to run callbacks.
@rafaelfranca I thought 3.2.8 was meant to remove all deprecations introduced after 3.2.0 ?
Yes, we removed the deprecation but not all the changes. See f203be9 and 81542f9.
Sorry guys. I should have reviewed this better before the release
toggle no longer triggers before_update aswell.
Do not use update_column where update_attribute is not interchangeable
Revert "Deprecate update_attribute."
This reverts commit b081f6b.
Reason: Since the new deprecation policy we removed the deprecation of
update_attribute but we didn't reverted the changes to use
@tobsch did you mean toggle!?
If so it was fixed with increment! and decrement! in my last commit.
So… are increment and increment! supposed to execute callbacks?