New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides: when migrating from 3.0, change NAME::Application.config.session_store #7685

Closed
drnic opened this Issue Sep 18, 2012 · 8 comments

Comments

Projects
None yet
4 participants
@drnic
Contributor

drnic commented Sep 18, 2012

In the guides for upgrading from Rails 3.0 to Rails 3.1, it would be helpful to document that the session_store key needs to be changed.

# config/initializers/session_store.rb
AppName::Application.config.session_store :cookie_store, :key => 'SOMETHINGNEW'

This migration step is also documented in this ticket #2509 (comment)

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Sep 18, 2012

Member

Come on, Nic, didn't you see we don't accept feature requests in Issues!

Regardless, I've pushed rails/docrails@1664093, which will take care of this for you. :p

Thanks for bringing it up. ❤️

Member

steveklabnik commented Sep 18, 2012

Come on, Nic, didn't you see we don't accept feature requests in Issues!

Regardless, I've pushed rails/docrails@1664093, which will take care of this for you. :p

Thanks for bringing it up. ❤️

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Sep 18, 2012

Member

Thanks

Member

rafaelfranca commented Sep 18, 2012

Thanks

@frodsan

This comment has been minimized.

Show comment
Hide comment
@frodsan

frodsan Sep 18, 2012

Contributor

I think it should be backported to 3-2-stable. This will go to edgeguides.

Contributor

frodsan commented Sep 18, 2012

I think it should be backported to 3-2-stable. This will go to edgeguides.

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Sep 18, 2012

Member

Open the pull request please.

Member

rafaelfranca commented Sep 18, 2012

Open the pull request please.

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Sep 18, 2012

Member

This guide doesn't exist on the 3-2-stable branch...

Member

steveklabnik commented Sep 18, 2012

This guide doesn't exist on the 3-2-stable branch...

@drnic

This comment has been minimized.

Show comment
Hide comment
@drnic

drnic Sep 18, 2012

Contributor

I couldn't quite figure out where the guides were now to make a patch; so I thought to quickly document what I learnt. Thanks guys!

Contributor

drnic commented Sep 18, 2012

I couldn't quite figure out where the guides were now to make a patch; so I thought to quickly document what I learnt. Thanks guys!

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik
Member

steveklabnik commented Sep 18, 2012

See #7686

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Sep 18, 2012

Member

@drnic no worries, I'm just messing with you. Better to bring it up than to not!

Member

steveklabnik commented Sep 18, 2012

@drnic no worries, I'm just messing with you. Better to bring it up than to not!

steveklabnik added a commit to steveklabnik/rails that referenced this issue Sep 18, 2012

steveklabnik added a commit that referenced this issue Sep 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment