Credit for previous commit #7990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
added a commit
that referenced
this pull request
Oct 18, 2012
Credit for previous commit [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
in my pull request that was already commited #6671
I forgot to include credit in the changelog (by the way, is it customary to put credit in any other place as well?). Since I see all the other changes have credit attributed I would like to include credit to myself and Egor Homakov who described the issue.
I'm not sure what the best way to do this is, so that it would not be a single commit just for this, perhaps the next time the ActiveModel changelog is changed?
Just in case I am attaching a pull request.
I'm sorry for the trouble :S
Thanks,
Jan