Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Cannot create I18n labels when using accepts_nested_attributes_for #805

Closed
lighthouse-import opened this Issue · 5 comments

2 participants

@lighthouse-import

Imported from Lighthouse. Original ticket at: http://rails.lighthouseapp.com/projects/8994/tickets/6273
Created by Paul Schreiber - 2011-01-10 17:16:44 UTC

Note: I am using Rails 2.3.10.

Normally, you can use Rails’ I18n system to generate label text.

For example, suppose you have a Person class with a name attribute. And this ERB:
<%= form_for @person do |f| %>
<%= f.label :name %>
<%= f.text_field :name %>
<% end %>

And you’d construct your en.yml like so:
en:
helpers:
label:
name: “your name”

However, this doesn’t work very well with related objects and accepts_nested_attributes_for. Suppose you have the same Person class as before. And person has_many :activities (likewise, activity belongs_to :person) and accepts_nested_attributes_for :activities.

Now your ERB looks like this:
<%= form_for @person do |f| %>
<%= f.label :name %>
<%= f.text_field :name %>
<% f.fields_for :activities do |a| %>
<%= l.label :difficulty %>
<%= l.text_field :difficulty %>
<% end %>
<% end %>

Various combinations indentation of person / activities / difficulty in my en.yml file didn’t work. So I looked inside rails to see what’s going on.

The relevant code is in actionpack-2.3.10/lib/action_view/helpers/form_helper.rb. The method used is

def to_label_tag(text = nil, options = {})
on line 758.

And the code doing the work is:
content = if text.blank?
i18n_label = I18n.t("helpers.label.#{object_name}.#{method_name}", :default => “”)
i18n_label if i18n_label.present?
else
text.to_s
end

The problem is you end up with a set of labels like:
helpers.label.person[activities_attributes][0].difficulty
helpers.label.person[activities_attributes][1].difficulty
helpers.label.person[activities_attributes][2].difficulty

@lighthouse-import

Imported from Lighthouse.
Comment by Alexey Nayden - 2011-01-23 23:53:35 UTC

The same problem found in rails 3.0.3

Here're test and patch

@lighthouse-import

Imported from Lighthouse.
Comment by rails - 2011-04-30 00:00:08 UTC

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

@lighthouse-import

Imported from Lighthouse.
Comment by Paul Schreiber - 2011-04-30 00:04:22 UTC

[state:open]

@paulschreiber

Can someone reopen this? It's still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.