Skip to content

Passing actions with colons to the controller generator #871

Closed
lighthouse-import opened this Issue May 16, 2011 · 2 comments

1 participant

@lighthouse-import

Imported from Lighthouse. Original ticket at: http://rails.lighthouseapp.com/projects/8994/tickets/6472
Created by Ilya Zayats - 2011-02-26 03:36:22 UTC

If we accidentally try to pass actions as symbols to the controller generator (so I do very often) it will break everything because we will have routes like this:
get "controller/:index"

And that will produce `default_controller_and_action': missing :controller (ArgumentError)' error

I've fixed that, now all colons or commas will be omitted in action names.

@lighthouse-import

Imported from Lighthouse.
Comment by Ilya Zayats - 2011-02-26 04:30:10 UTC

Updated patch to get rid of the second gsub call

@lighthouse-import

Attachments saved to Gist: http://gist.github.com/971786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.