Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprockets 2.2.x backport #9492

Closed
josh opened this Issue Feb 28, 2013 · 11 comments

Comments

Projects
None yet
9 participants
@josh
Copy link
Member

josh commented Feb 28, 2013

Its been 10 months since anyone using sprockets on Rails has received any bug fixes or enhancements.

The restrictive lock to 2.2.2 has been frustrating to work with internally at GitHub. We have a quite a few internal apps on 3.x and keep getting bit by the same sprockets bugs that are fixed on new version. I've had to resort to some pretty bad hacks to get the new patches backported for them. I always thought bundler could make this easier, but doesn't really have a mechanize for "just make these gem versions work". I'm basically sick dealing with this problem and I'm taking some immediate action to make this situation a little better.

My plan is to ship a backported 2.9.0 gem as 2.2.2.backport1 to be compatible with the actionpack version restriction. The gem will be marked as a prelease so no one will automatically be upgraded. You'll choose to opt in by putting it in your Gemfile.

gem "sprockets", "2.2.2.backport1"

I know theres some minor edge issues with sprockets 2.3 (I suppose) and the Rails test suite right now. But theres also so many other fixes people aren't getting. I've been running edge Sprockets on most of our apps of all sorts of Rails versions with no issues.

/cc @dhh @jeremy @carlosantoniodasilva @josevalim @rafaelfranca @guilleiguaran

@ajsharp

This comment has been minimized.

Copy link

ajsharp commented Feb 28, 2013

+1

@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Feb 28, 2013

Seems a good plan.

But I really want to fix the issues and remove the restrictive lock

@ndbroadbent

This comment has been minimized.

Copy link
Contributor

ndbroadbent commented Feb 28, 2013

+1

@josh

This comment has been minimized.

Copy link
Member Author

josh commented Feb 28, 2013

Since this seems specific to sass-rails, another thing we can do is release the hard lock in actionpack.gemspec and add the specific requirement to sass-rails.gemspec.

@josh

This comment has been minimized.

@josh josh closed this Feb 28, 2013

@jeremy

This comment has been minimized.

Copy link
Member

jeremy commented Feb 28, 2013

We ran sprockets master for a while on Rails 3-2-stable without issues. Sucks to be stuck on the old version for sure. @rafaelfranca what was the blocker bug?

@rafaelfranca

This comment has been minimized.

Copy link
Member

rafaelfranca commented Feb 28, 2013

@guilleiguaran

This comment has been minimized.

Copy link
Member

guilleiguaran commented Feb 28, 2013

The bug is #8099 but I agree, I would like to use last version of sprockets (and sprockets-rails) with rails 3-2-stable.

Maybe we can relax the dependency to "~> 2.2" and affected users can keep 2.2 version while unaffected users (almost all) can use last version?

@swrobel

This comment has been minimized.

Copy link
Contributor

swrobel commented Apr 4, 2013

@josh is there a branch/tag for the backport?

@SamSaffron

This comment has been minimized.

Copy link
Contributor

SamSaffron commented Apr 8, 2013

@josh

Can we backport sstephenson/sprockets#428 once merged as well?

note, we use sass-rails at discourse and are not experiencing any issues when I fuddled with versions

cc @rafaelfranca

@timcraft

This comment has been minimized.

Copy link

timcraft commented Apr 24, 2013

@josh Thanks for the backport! Just ran into this issue whilst trying to get at this change in sprockets.

wcch pushed a commit to wcch/pophealth53 that referenced this issue Nov 22, 2013

restructure assets to make room for new approach
* use sprockets 2.2.2.backport1 (see: rails/rails#9492)
* use require.js via requirejs-rails
* manage future front-end assets via bower
* move old assets into archive directories
* modify old layouts to reference archived assets
* create new layout, app/views/layouts/application_future
* create new view, app/views/measures/new_dash, for displaying new dashboard markup


Former-commit-id: 4856c0d

rdingwell pushed a commit to rdingwell/popHealth that referenced this issue Dec 3, 2013

restructure assets to make room for new approach
* use sprockets 2.2.2.backport1 (see: rails/rails#9492)
* use require.js via requirejs-rails
* manage future front-end assets via bower
* move old assets into archive directories
* modify old layouts to reference archived assets
* create new layout, app/views/layouts/application_future
* create new view, app/views/measures/new_dash, for displaying new dashboard markup

raj209 pushed a commit to raj209/PopHealth_Testing that referenced this issue Sep 26, 2017

restructure assets to make room for new approach
* use sprockets 2.2.2.backport1 (see: rails/rails#9492)
* use require.js via requirejs-rails
* manage future front-end assets via bower
* move old assets into archive directories
* modify old layouts to reference archived assets
* create new layout, app/views/layouts/application_future
* create new view, app/views/measures/new_dash, for displaying new dashboard markup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.