Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Sprockets 2.2.x backport #9492

Closed
josh opened this Issue · 11 comments

9 participants

@josh
Collaborator

Its been 10 months since anyone using sprockets on Rails has received any bug fixes or enhancements.

The restrictive lock to 2.2.2 has been frustrating to work with internally at GitHub. We have a quite a few internal apps on 3.x and keep getting bit by the same sprockets bugs that are fixed on new version. I've had to resort to some pretty bad hacks to get the new patches backported for them. I always thought bundler could make this easier, but doesn't really have a mechanize for "just make these gem versions work". I'm basically sick dealing with this problem and I'm taking some immediate action to make this situation a little better.

My plan is to ship a backported 2.9.0 gem as 2.2.2.backport1 to be compatible with the actionpack version restriction. The gem will be marked as a prelease so no one will automatically be upgraded. You'll choose to opt in by putting it in your Gemfile.

gem "sprockets", "2.2.2.backport1"

I know theres some minor edge issues with sprockets 2.3 (I suppose) and the Rails test suite right now. But theres also so many other fixes people aren't getting. I've been running edge Sprockets on most of our apps of all sorts of Rails versions with no issues.

/cc @dhh @jeremy @carlosantoniodasilva @josevalim @rafaelfranca @guilleiguaran

@ajsharp

+1

@rafaelfranca

Seems a good plan.

But I really want to fix the issues and remove the restrictive lock

@josh
Collaborator

Since this seems specific to sass-rails, another thing we can do is release the hard lock in actionpack.gemspec and add the specific requirement to sass-rails.gemspec.

@josh josh closed this
@jeremy
Owner

We ran sprockets master for a while on Rails 3-2-stable without issues. Sucks to be stuck on the old version for sure. @rafaelfranca what was the blocker bug?

@guilleiguaran

The bug is #8099 but I agree, I would like to use last version of sprockets (and sprockets-rails) with rails 3-2-stable.

Maybe we can relax the dependency to "~> 2.2" and affected users can keep 2.2 version while unaffected users (almost all) can use last version?

@martijnwalraven martijnwalraven referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@swrobel

@josh is there a branch/tag for the backport?

@SamSaffron

@josh

Can we backport sstephenson/sprockets#428 once merged as well?

note, we use sass-rails at discourse and are not experiencing any issues when I fuddled with versions

cc @rafaelfranca

@timcraft

@josh Thanks for the backport! Just ran into this issue whilst trying to get at this change in sprockets.

@carpeliam carpeliam referenced this issue in pophealth/popHealth
Merged

restructure assets to make room for new approach #55

@wcch wcch referenced this issue from a commit in wcch/pophealth53
@carpeliam carpeliam restructure assets to make room for new approach
* use sprockets 2.2.2.backport1 (see: rails/rails#9492)
* use require.js via requirejs-rails
* manage future front-end assets via bower
* move old assets into archive directories
* modify old layouts to reference archived assets
* create new layout, app/views/layouts/application_future
* create new view, app/views/measures/new_dash, for displaying new dashboard markup


Former-commit-id: 4856c0d
9577f61
@rdingwell rdingwell referenced this issue from a commit in rdingwell/popHealth
@carpeliam carpeliam restructure assets to make room for new approach
* use sprockets 2.2.2.backport1 (see: rails/rails#9492)
* use require.js via requirejs-rails
* manage future front-end assets via bower
* move old assets into archive directories
* modify old layouts to reference archived assets
* create new layout, app/views/layouts/application_future
* create new view, app/views/measures/new_dash, for displaying new dashboard markup
4856c0d
@mikecarroll mikecarroll referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.