Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Inflection error in active_support-3.2.12 which don't exist in 4.0.0.beta1 #9559

Closed
prijutme4ty opened this Issue · 5 comments

5 participants

@prijutme4ty

gem 'activesupport', '3.2.13.rc1' # 3.2.12 works the same
require 'active_support/core_ext/string/inflections'
'address'.singularize # => 'addres'

gem 'activesupport', '4.0.0.beta1'
require 'active_support/core_ext/string/inflections'
'address'.singularize # => 'address'

I think, it should be either backported to 3.2 or at least mentioned as change in 4.0.0 (unfortnately I don't know which commit caused such behavior change)

@carlosantoniodasilva

@fxn perhaps you know off the top of your head?

@fxn
Owner
fxn commented

Could be related to ef4ac7a?

@prijutme4ty

No, looks that 532cd49 is responsible for these changes.
Can it be backported or Inflector for 3.2 is frozen?

@rafaelfranca
Owner

I don't think this change should be backported, but it should be documented in the CHANGELOG

@senny
Owner

I agree with @rafaelfranca that we should not backport. That the fix will only affect Rails 4 is already documented in the original PR disucssion #4719. I submitted a PR with the CHANGELOG to make sure it is documented.

@senny senny closed this issue from a commit
@senny senny CHANGELOG entry for improved singularizing of singulars.
Closes #9559.

The actual patch was added with #4719
f8b0e54
@senny senny closed this in f8b0e54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.