Engines don't have a valid gemspec #9589

Closed
steveklabnik opened this Issue Mar 6, 2013 · 10 comments

Comments

Projects
None yet
8 participants
@steveklabnik
Member

steveklabnik commented Mar 6, 2013

When I create an engine with rails plugin new blorgh --mountable, I get

Using blorgh (0.0.1) from source at /Users/steve/tmp/blorgh 
blorgh at /Users/steve/tmp/blorgh did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
  "FIXME" or "TODO" is not an author
@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 6, 2013

Member

I'm not sure what the right way is to fix this: we want to have a not-real gem, but then we get that error.

@drbrain what do you think?

Member

steveklabnik commented Mar 6, 2013

I'm not sure what the right way is to fix this: we want to have a not-real gem, but then we get that error.

@drbrain what do you think?

@schneems

This comment has been minimized.

Show comment Hide comment
@schneems

schneems Mar 8, 2013

Member

Crazy idea: what if the generator prompts you for the fields it needs?

$ rails plugin new blorgh --mountable

Rails plugins are now used as gems, to create a valid gemspec enter in a valid 
email address, you can change it later by mofifying `foo.gemspec`

Enter your email > 

#...
Member

schneems commented Mar 8, 2013

Crazy idea: what if the generator prompts you for the fields it needs?

$ rails plugin new blorgh --mountable

Rails plugins are now used as gems, to create a valid gemspec enter in a valid 
email address, you can change it later by mofifying `foo.gemspec`

Enter your email > 

#...
@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 8, 2013

Member

I like that idea. The only other real option we have is to build the gem with --force the first time.

Member

steveklabnik commented Mar 8, 2013

I like that idea. The only other real option we have is to build the gem with --force the first time.

@claudiob

This comment has been minimized.

Show comment Hide comment
@claudiob

claudiob Mar 8, 2013

Member

The required fields are authors, email, homepage, summary and description.

I have the feeling that, with so many fields, a programmer would just write random, meaningless text (especially for homepage, summary and description), and then forget to replace with meaningful entries.

I'd rather the programmer can start writing some code, and it's only asked for those values once the gem gets explicitly built. How do you feel about that?

Member

claudiob commented Mar 8, 2013

The required fields are authors, email, homepage, summary and description.

I have the feeling that, with so many fields, a programmer would just write random, meaningless text (especially for homepage, summary and description), and then forget to replace with meaningful entries.

I'd rather the programmer can start writing some code, and it's only asked for those values once the gem gets explicitly built. How do you feel about that?

@steveklabnik

This comment has been minimized.

Show comment Hide comment
@steveklabnik

steveklabnik Mar 9, 2013

Member

The issue is that in order to build all the dependencies bundler needs to build the gem.

Member

steveklabnik commented Mar 9, 2013

The issue is that in order to build all the dependencies bundler needs to build the gem.

@drbrain

This comment has been minimized.

Show comment Hide comment
@drbrain

drbrain Mar 9, 2013

It's probably best to use valid, dummy entries on the first build then replace them with FIXME after the first install.

drbrain commented Mar 9, 2013

It's probably best to use valid, dummy entries on the first build then replace them with FIXME after the first install.

@Val

This comment has been minimized.

Show comment Hide comment
@Val

Val Mar 22, 2013

RubyGems developers should provide a convenient way to build non-final gems : we are developers too !

sudo ruby -e "print gets(nil).gsub(/(# reject lazy developers.*)(# Warnings)/m, '\2')" -i /path_to/rubygems/specification.rb

It's a bad workarround I know...
But now I can use templating to test /build my rails plugins :-P

Val commented Mar 22, 2013

RubyGems developers should provide a convenient way to build non-final gems : we are developers too !

sudo ruby -e "print gets(nil).gsub(/(# reject lazy developers.*)(# Warnings)/m, '\2')" -i /path_to/rubygems/specification.rb

It's a bad workarround I know...
But now I can use templating to test /build my rails plugins :-P

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca May 1, 2014

Owner

This issue has been automatically marked as stale because it has not been commented on for at least
three months.

The resources of the Rails team are limited, and so we are asking for your help.

If you can still reproduce this error on the 4-1-stable, 4-0-stable branches or on master,
please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions.

Owner

rafaelfranca commented May 1, 2014

This issue has been automatically marked as stale because it has not been commented on for at least
three months.

The resources of the Rails team are limited, and so we are asking for your help.

If you can still reproduce this error on the 4-1-stable, 4-0-stable branches or on master,
please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions.

@robin850 robin850 added attached PR and removed stale labels May 2, 2014

@arunagw

This comment has been minimized.

Show comment Hide comment
@arunagw

arunagw May 2, 2014

Member

@rafaelfranca a PR is here for this one #14941

Member

arunagw commented May 2, 2014

@rafaelfranca a PR is here for this one #14941

@rafaelfranca

This comment has been minimized.

Show comment Hide comment
@rafaelfranca

rafaelfranca May 2, 2014

Owner

Closed by #14941

Owner

rafaelfranca commented May 2, 2014

Closed by #14941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment