This is a Rails 4.0.0.beta1 regression.
The deprecation warning in ActiveRecord::Relation::references_eager_loaded_tables? fires whenever a query contains an includes and an e-mail value. In fact, the regular expression used to scan for table names is really brittle. (which is why this warning came to be in the first place)
The rate of false positives makes the warning really annoying, as it litters my unit test output. Please consider either
The regexp problem was documented in #7177
I agree that having a deprecation warning that fires without being able to solve the problem is annoying. I would implement option 1 as it replicated the behaviour after the deprecation. The only downside is that we than have to deprecate the option with 4.1.
@senny option 1 sounds sensible.
@senny do you want to work on this? if not I'll do it.
@jonleighton I'm on it.
make it possible to disable implicit join references.
Thank you very much!!
Add explicit join references in models
Signed-off-by: Alex Coles <firstname.lastname@example.org>