Refactor scoping test files #10003

Merged
merged 3 commits into from Mar 30, 2013

Conversation

Projects
None yet
3 participants
@take
Contributor

take commented Mar 30, 2013

check commit message/description for what i've done 馃槃

take added some commits Mar 30, 2013

move tests for NamedScope and DefaultScope under test/cases/scoping/
The scoping/default.rb and scoping/named.rb got moved under scoping/ in
commit 2b22564,
but the tests never did.
rename named_scope_test.rb to a proper file name
The file name should be name_scoping_test.rb and the class should be
`NamedScopingTest` according to ActiveRecord::Scoping::Name
@neerajdotname

This comment has been minimized.

Show comment Hide comment
@neerajdotname

neerajdotname Mar 30, 2013

Member

Personally I like the consistency this PR brings.

Could you please post test summary before and after the patch to ensure that number of assertions is not lost during this translation? Thank you.

Member

neerajdotname commented Mar 30, 2013

Personally I like the consistency this PR brings.

Could you please post test summary before and after the patch to ensure that number of assertions is not lost during this translation? Thank you.

@take

This comment has been minimized.

Show comment Hide comment
@take

take Mar 30, 2013

Contributor

@neerajdotname

Personally I like the consistency this PR brings.

Thx! 馃槃 It was really hard to reach to the tests when I was reading the codes for scoping/default.rb, scoping/named.rb so yea :D

Could you please post test summary before and after the patch to ensure that number of assertions is not lost during this translation? Thank you.

Sure thing! 馃槃

Contributor

take commented Mar 30, 2013

@neerajdotname

Personally I like the consistency this PR brings.

Thx! 馃槃 It was really hard to reach to the tests when I was reading the codes for scoping/default.rb, scoping/named.rb so yea :D

Could you please post test summary before and after the patch to ensure that number of assertions is not lost during this translation? Thank you.

Sure thing! 馃槃

@take

This comment has been minimized.

Show comment Hide comment
@take

take Mar 30, 2013

Contributor

@neerajdotname

output of git log

 2013-03-30 23 14 11

Tests result for 022ed6c

3635 tests, 10369 assertions, 0 failures, 0 errors, 27 skips

 2013-03-30 23 34 34

Tests result for 7be9e88

3635 tests, 10369 assertions, 0 failures, 0 errors, 27 skips

 2013-03-30 23 39 30

Contributor

take commented Mar 30, 2013

@neerajdotname

output of git log

 2013-03-30 23 14 11

Tests result for 022ed6c

3635 tests, 10369 assertions, 0 failures, 0 errors, 27 skips

 2013-03-30 23 34 34

Tests result for 7be9e88

3635 tests, 10369 assertions, 0 failures, 0 errors, 27 skips

 2013-03-30 23 39 30

@neerajdotname

This comment has been minimized.

Show comment Hide comment
@neerajdotname

neerajdotname Mar 30, 2013

Member

@tkhr thanks.

Member

neerajdotname commented Mar 30, 2013

@tkhr thanks.

carlosantoniodasilva added a commit that referenced this pull request Mar 30, 2013

@carlosantoniodasilva carlosantoniodasilva merged commit bacae87 into rails:master Mar 30, 2013

@carlosantoniodasilva

This comment has been minimized.

Show comment Hide comment
@carlosantoniodasilva

carlosantoniodasilva Mar 30, 2013

Owner

Thanks.

Thanks.

@take

This comment has been minimized.

Show comment Hide comment
@take

take Mar 31, 2013

Contributor

yw 馃槃

Contributor

take commented Mar 31, 2013

yw 馃槃

@take take deleted the take:refactor-scoping-test-files branch Mar 31, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment