Refactor render_to_string so it's a little shorter and simpler. #10023

Closed
wants to merge 1 commit into
from

3 participants

@orend

No description provided.

@steveklabnik
Ruby on Rails member

I'm going to make a judgement call here: we don't normally accept 'cosmetic' changes, and these 'refactorings' are so small that I don't think it's worth changing the history for. If they were part of larger changes, they'd be fine, but by themselves, it's not enough.

Thank you for your contribution, though! I'm sorry I can't accept it. ❤️.

@jeremy
Ruby on Rails member

@orend trouble is, response_body is only guaranteed to respond to #each, not all of Enumerable 😁

@orend

@jeremy :-o
@steveklabnik no worries. Thanks for taking the time to explain the policy. I'll know for next (correct!) PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment