Remove rails.png.

[steveklabnik]

No reason to have a file, we've got data-URIs now! It didn't make sense
to me that you no longer have to remove public/index.html, but you still
need to remove rails.png. This means that you won't have to any more
when making a new Rails app.

Now, a bunch of Railties tests fail because we use the fact that we know that rails.png exists to test them. I wanted to submit this as a PR to get feedback about the idea before I spent the time figuring out how to deal with that.

/cc @dhh

[pablof7z]

I celebrate most times a file is deleted or code removed from rails/rails. This is no exception. 👍

[chrismccord]

👍

[assimovt]

👍

[qrush]

👎, I think this is good for at least "Where do I put images in my app?"

[ejholmes]

👍

[amiel]

👍 It's a file that tends to stagnate in many projects. I'm always deleting it, but usually 3 months after the project was created because it was forgotten about.

And even if it's remembered early, it's still taking up space in git history.

[josevalim]

@qrush I think it is ok to delete the file as long as we add a .gitkeep to the app/assets/images directory.

[buddhamagnet]

I actually have a small script that removes the index.html and rails.png files. I tutted when I had to use it again today. This is good.

[reinh]

👍

[gregmolnar]

👍

[chrismccord]

@qrush I think a .gitkeep in app/assets/images should suffice

[aviflombaum]

👍 ya, no reason to precompile it either.

[rafaelfranca]

👍 with the .gitkeep

[mhenrixon]

👍

[heimidal]

👍 I always forget that I need to delete it, and have wondered why it wasn't being handled with data-URI since index.html disappeared.

[mdespuits]

👍 Yes please! please! please!

[DevL]

👍

[bai]

👍

[steveklabnik]

🤘

I'll commit test fixes soon. Working on them right now...

[frodsan]

Does it need a CHANGELOG entry btw?

[steveklabnik]

Good call. fc11375

[dhh]

IMO no need for a changelog entry. Nobody is going to care. Doesn't change anything for anyone in terms of functionality.

On Apr 2, 2013, at 17:38, Steve Klabnik notifications@github.com wrote:

Good call. fc11375

—
Reply to this email directly or view it on GitHub.

[carlosantoniodasilva]

I can just think of a few templates trying to remove rails.png that might fail and will need to be changed now.