New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per #9999 revert blank? to empty? #10063

Merged
merged 1 commit into from Apr 3, 2013

Conversation

Projects
None yet
3 participants
@SamSaffron
Copy link
Contributor

SamSaffron commented Apr 3, 2013

Change blank? in column.rb to empty?

This is both faster and more correct, added tests to make sure this is not reverted again.

Per #9999 revert the revert changing so columns are only tested for e…
…mpty? as opposed to blank?

This is both faster and more correct, added tests to make sure this is not reverted again.
@carlosantoniodasilva

This comment has been minimized.

Copy link
Member

carlosantoniodasilva commented Apr 3, 2013

Seems good to me.

@tenderlove any comments?

@carlosantoniodasilva

This comment has been minimized.

Copy link
Member

carlosantoniodasilva commented Apr 3, 2013

Thanks @SamSaffron 👍

spastorino added a commit that referenced this pull request Apr 3, 2013

Merge pull request #10063 from SamSaffron/master
Per #9999 revert blank? to empty?

@spastorino spastorino merged commit a7ef098 into rails:master Apr 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment