Avoid running bundler on tests that don't need it #10070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @steveklabnik |
|
This is awesome! |
| @@ -61,7 +61,10 @@ def destination(path) | |||
| # You can provide a configuration hash as second argument. This method returns the output | |||
| # printed by the generator. | |||
| def run_generator(args=self.default_arguments, config={}) | |||
| capture(:stdout) { self.generator_class.start(args, config.reverse_merge(destination_root: destination_root)) } | |||
| capture(:stdout) do | |||
| args << '--skip-bundle' unless args.include? '--dev' | |||
There was a problem hiding this comment.
Just wondering: can't this "mutate" the default_arguments option in different runs?
|
Awesome @rubys, thank you |
|
great! maybe we can squash the commits together. |
|
|
pixeltrix
added a commit
that referenced
this pull request
Apr 3, 2013
Avoid running bundler on tests that don't need it
|
Thank you very much sir!!! |
|
Soooooo good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Railties test timings on Intel(R) Core(TM) i3 CPU 550 @ 3.20GHz
Before: 18m19.854s
After: 8m57.653s