Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

each to each_value; remove unused vars #10127

Merged
merged 1 commit into from

2 participants

@vipulnsward
  1. each to each_value
  2. remove unused vars
@carlosantoniodasilva carlosantoniodasilva merged commit 1eee481 into rails:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 7, 2013
  1. @vipulnsward
This page is out of date. Refresh to see the latest.
View
2  activerecord/lib/active_record/associations/preloader/has_many_through.rb
@@ -5,7 +5,7 @@ class HasManyThrough < CollectionAssociation #:nodoc:
include ThroughAssociation
def associated_records_by_owner
- super.each do |owner, records|
+ super.each_value do |records|
records.uniq! if reflection_scope.distinct_value
end
end
View
4 activerecord/test/cases/adapters/sqlite3/copy_table_test.rb
@@ -54,7 +54,7 @@ def test_copy_table_without_primary_key
end
def test_copy_table_with_id_col_that_is_not_primary_key
- test_copy_table('goofy_string_id', 'goofy_string_id2') do |from, to, options|
+ test_copy_table('goofy_string_id', 'goofy_string_id2') do
original_id = @connection.columns('goofy_string_id').detect{|col| col.name == 'id' }
copied_id = @connection.columns('goofy_string_id2').detect{|col| col.name == 'id' }
assert_equal original_id.type, copied_id.type
@@ -65,7 +65,7 @@ def test_copy_table_with_id_col_that_is_not_primary_key
end
def test_copy_table_with_unconventional_primary_key
- test_copy_table('owners', 'owners_unconventional') do |from, to, options|
+ test_copy_table('owners', 'owners_unconventional') do
original_pk = @connection.primary_key('owners')
copied_pk = @connection.primary_key('owners_unconventional')
assert_equal original_pk, copied_pk
Something went wrong with that request. Please try again.