Mark unused block parameters. #10130

Merged
merged 1 commit into from Apr 8, 2013

3 participants

@agis-

Ruby 2 💪

@steveklabnik
Ruby on Rails member

Wouldn't it be better to use _?

@agis-

That was my initial thought, but then again I thought that it may be sweeter for people who read the code if we take advantage of the "don't care variables" that ruby 2.0 has, in order to make maintenance easier and not hide information regarding the API.

What do you think?

@steveklabnik
Ruby on Rails member

I personally would just use _, but let's wait for someone else to chime in. I'm not sure what's standard here.

@carlosantoniodasilva
Ruby on Rails member

I kinda like the idea of named variables to make them more explicit.

@carlosantoniodasilva carlosantoniodasilva merged commit 0d8a76d into rails:master Apr 8, 2013
@agis- agis- deleted the unknown repository branch Apr 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment