Fix inflector to respect default locale. #10158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inflector was made aware of locales in 7db0b07, but it defaulted to :en. That should actually be our default locale instead. Fixes rails#10125
|
|
steveklabnik
added a commit
that referenced
this pull request
Apr 10, 2013
Fix inflector to respect default locale.
|
Word, thanks. |
| assert_equal('region', 'regionen'.singularize) | ||
| ensure | ||
| I18n.locale = old_locale | ||
| end |
There was a problem hiding this comment.
You might wanna use I18n.with_locale(:de) do ... end for that purpose. (https://github.com/svenfuchs/i18n/blob/master/lib/i18n.rb#L243-L251)
|
This issues is not only with Active Record but also routes, rails rendering stack, anywhere that may call pluralize. This definitely needs to be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The inflector was made aware of locales in 7db0b07,
but it defaulted to :en. That should actually be our default
locale instead.
Fixes #10125
I wanted to get some feedback about the tests. Is this the right place, or should I bet testing singularize/pluralize more directly?
/cc @thenickcox