Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Serialized column should not be wrapped twice. Fix #10067. #10330

Merged
merged 2 commits into from Apr 24, 2013

Conversation

Projects
None yet
4 participants
Contributor

kennyj commented Apr 24, 2013

See #10067

If AR's instance has serialized attribute ( or timezone aware attribute), instance level @columns_hash is wrapped multiple times during instantiate in current implementation.

Owner

rafaelfranca commented Apr 24, 2013

@kennyj could you add a CHANGELOG entry with a description of the problem?

Owner

rafaelfranca commented Apr 24, 2013

Also I think we should call the dup inside the instantiate metod like was did at #10067 (methods should not mutate their arguments)

Contributor

kennyj commented Apr 24, 2013

ok. just a moment.

Contributor

mdespuits commented Apr 24, 2013

Looks like there are some dupicate commits from master.

Contributor

kennyj commented Apr 24, 2013

@mattdbridges thanks for reporting. I've update this PR aginn. Is this ok ?
@rafaelfranca I've update this PR.

Contributor

mdespuits commented Apr 24, 2013

@kennyj Looks like 2461deb4 is the only one still dangling. Can you squash your commits?

Contributor

kennyj commented Apr 24, 2013

I've updated again.
@mattdbridges I'm afraid that disappearing @derikson 's contribution. so I've squashed my commits only.

Contributor

mdespuits commented Apr 24, 2013

@kennyj Gotcha. Looks good to me

@rafaelfranca rafaelfranca added a commit that referenced this pull request Apr 24, 2013

@rafaelfranca rafaelfranca Merge pull request #10330 from kennyj/fix_10067
Serialized column should not be wrapped twice. Fix #10067.
4e3eca4

@rafaelfranca rafaelfranca merged commit 4e3eca4 into rails:master Apr 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment