Fix a failing test in actionpack #10356

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@robin850
Member

Hello,

This pull request just fix a failing test in Action Pack.

Have a nice day.

@pixeltrix
Member

Where's it failing? The Travis CI isn't showing anything.

@robin850
Member

Without the patch, when I run the test suite (with bundle exec rake test) I've got:

1) Failure:
ActionController::LiveStreamTest#test_exception_callback [/home/robin/code/contribute/rails/actionpack/test/controller/live_stream_test.rb:185]:
Expected /An\ exception\ occurred\.\.\./ to match "Processing by ActionController::LiveStreamTest::TestController#exception_with_callback as \nCompleted 500 Internal Server Error in 0ms\n".
@fxn
Member
fxn commented Apr 26, 2013

Yep, that happens systematically in the dev box. Had it pending for PDI.

@robin850
Member

Should I close this or it will be merge later please? 😄

@robin850
Member

/cc @fxn

@carlosantoniodasilva

Closing here guys, please feel free to reopen if you want to track anything from here. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment