Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix a failing test in actionpack #10356

Closed
wants to merge 1 commit into from

4 participants

Robin Dupret Andrew White Xavier Noria Carlos Antonio da Silva
Robin Dupret
Collaborator

Hello,

This pull request just fix a failing test in Action Pack.

Have a nice day.

Andrew White
Owner

Where's it failing? The Travis CI isn't showing anything.

Robin Dupret
Collaborator

Without the patch, when I run the test suite (with bundle exec rake test) I've got:

1) Failure:
ActionController::LiveStreamTest#test_exception_callback [/home/robin/code/contribute/rails/actionpack/test/controller/live_stream_test.rb:185]:
Expected /An\ exception\ occurred\.\.\./ to match "Processing by ActionController::LiveStreamTest::TestController#exception_with_callback as \nCompleted 500 Internal Server Error in 0ms\n".
Xavier Noria
Owner

Yep, that happens systematically in the dev box. Had it pending for PDI.

Robin Dupret
Collaborator

Should I close this or it will be merge later please? :smile:

Robin Dupret
Collaborator

/cc @fxn

Carlos Antonio da Silva

Closing here guys, please feel free to reopen if you want to track anything from here. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 26, 2013
  1. Robin Dupret
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  actionpack/test/controller/live_stream_test.rb
2  actionpack/test/controller/live_stream_test.rb
View
@@ -182,7 +182,7 @@ def test_exception_callback
capture_log_output do |output|
get :exception_with_callback, format: 'text/event-stream'
assert_equal %(data: "500 Internal Server Error"\n\n), response.body
- assert_match 'An exception occurred...', output.rewind && output.read
+ assert_match 'Completed 500 Internal Server Error', output.rewind && output.read
assert_stream_closed
end
end
Something went wrong with that request. Please try again.