Remove varargs from in 4 0 stable #10397

Merged
merged 2 commits into from May 1, 2013

Conversation

Projects
None yet
2 participants
Contributor

BMorearty commented May 1, 2013

Same diff as rails/rails#10394, but for 4-0-stable. Please discuss on that pull request, not this one.

BMorearty added some commits May 1, 2013

@BMorearty BMorearty Revert "Object#in? also accepts multiple parameters"
This reverts commit ebf69ab.

`in?` must not take multiple parameters because its behavior would be
ambiguous:

    # Test if "B" is included in a list of names with `"B".in?(*names)`:
    names = ["BMorearty"]
    "B".in?(*names)   # => true

    names = ["BMorearty","rubyduo"]
    "B".in?(*names)   # => false

Conflicts:
	activesupport/lib/active_support/core_ext/object/inclusion.rb
	activesupport/test/core_ext/object/inclusion_test.rb
88eb1a8
@BMorearty BMorearty Revert the guide after removing varargs from `in?`. 275a064

@rafaelfranca rafaelfranca added a commit that referenced this pull request May 1, 2013

@rafaelfranca rafaelfranca Merge pull request #10397 from BMorearty/remove-varargs-from-in-4-0-s…
…table

Remove varargs from in 4 0 stable
a8ef0bb

@rafaelfranca rafaelfranca merged commit a8ef0bb into rails:4-0-stable May 1, 2013

@carlosantoniodasilva carlosantoniodasilva added a commit to carlosantoniodasilva/rails that referenced this pull request May 14, 2013

@carlosantoniodasilva carlosantoniodasilva Revert "Merge pull request #10397 from BMorearty/remove-varargs-from-…
…in-4-0-stable"

This reverts commit a8ef0bb, reversing
changes made to 1296adb.

Reason: Partially revert this commit and properly deprecate #in? with
multiple arguments in 4-0.
c273cb6

@carlosantoniodasilva carlosantoniodasilva added a commit that referenced this pull request May 14, 2013

@carlosantoniodasilva carlosantoniodasilva Revert "Merge pull request #10397 from BMorearty/remove-varargs-from-…
…in-4-0-stable"

This reverts commit a8ef0bb, reversing
changes made to 1296adb.

Reason: Partially revert this commit and properly deprecate #in? with
multiple arguments in 4-0.
c6ef49f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment