Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rake install task depend on build instead of gem #10465

Merged

Conversation

raphweiner
Copy link

The rake task doesn't build the Rails gem file so it couldn't be installed. The build task builds all the sub-gems and the Rails gem

The rake task doesn't build the Rails gem file so it couldn't be installed. The build task builds all the sub-gems and the Rails gem
rafaelfranca added a commit that referenced this pull request May 4, 2013
Make rake install task depend on build instead of gem
@rafaelfranca rafaelfranca merged commit dfb4647 into rails:4-0-stable May 4, 2013
@rafaelfranca
Copy link
Member

Thank you

rafaelfranca added a commit that referenced this pull request May 4, 2013
Make rake install task depend on build instead of gem
zenspider added a commit to zenspider/rails that referenced this pull request May 15, 2020
* master: (21 commits)
  fix failing test caused by 3771e4d
  let rake tasks be robust to a missing RDoc in Rubinius [Fixes rails#10462]
  raise IrreversibleMigration if no column given
  remove unused variable
  Fix typo in documentation comment
  use destructive sort on array in Hash#to_param for performance gains. Check https://gist.github.com/vipulnsward/6aad158c06a22f931a71 to see the gains.
  use nokogirisax as a backend
  Updated link to to GitHub article about ignoring files [ci skip]
  Github -> GitHub [ci skip]
  Fixes warning 'method redefined' in scaffold generators tests
  Added missing `require` to ActionView::LookupContext
  Merge pull request rails#10465 from raphweiner/rake_install_depend_on_build
  fix to remove warning on postgres adapter test.
  Changing method call according to coding conventions
  dir -> directory [ci skip]
  Use Ruby 1.9 syntax
  Review the CHANGELOG entry [ci skip]
  Fixes Scaffold generator with --assets=false
  generate 'app/assets/images' directory when creating new rails app
  Relaxed jbuilder dependency in Gemfile template
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants