Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix failing test caused by 3771e4d511 #10488

Merged
merged 1 commit into from May 6, 2013

Conversation

Projects
None yet
2 participants
Owner

rafaelfranca commented May 6, 2013

Not sure if I follow. The tests in only failing to 4-0-stable, master is green. What is the cause?

Member

neerajdotname commented May 6, 2013

Hmm.. I'm not sure why it passed in master. It should have failed.

Either way the current code where I'm putting a text column as an index is error prone. So I think the PR has better fix.

Also the code that is being tested does not care if it is string or text .

@rafaelfranca rafaelfranca added a commit that referenced this pull request May 6, 2013

@rafaelfranca rafaelfranca Merge pull request #10488 from neerajdotname/10419-b
fix failing test caused by 3771e4d
2291d0b

@rafaelfranca rafaelfranca merged commit 2291d0b into rails:master May 6, 2013

Owner

rafaelfranca commented May 6, 2013

Weird, now it is faling on master

Owner

rafaelfranca commented May 6, 2013

Thanks ❤️

@rafaelfranca rafaelfranca added a commit that referenced this pull request May 6, 2013

@rafaelfranca rafaelfranca Merge pull request #10488 from neerajdotname/10419-b
fix failing test caused by 3771e4d
2d74a4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment