Delete in-memory association record #10499

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@neerajdotname
Member

neerajdotname commented May 7, 2013

When target record is deleted then in-memory association
record should be deleted for hm:t case.

Fixes #9548

@neerajdotname

This comment has been minimized.

Show comment Hide comment
@neerajdotname

neerajdotname Jun 13, 2013

Member

@jonleighton can you look into this one too ?

Member

neerajdotname commented Jun 13, 2013

@jonleighton can you look into this one too ?

Neeraj Singh
Delete in-memory association record
When target record is deleted then in-memory association
record should be deleted for hm:t case.

Fixes #9548
@laurocaetano

This comment has been minimized.

Show comment Hide comment
@laurocaetano

laurocaetano Nov 30, 2013

Contributor

I've tried your branch locally and it seems to fix the issue. What do you think about changing the test to something like @senny did in this comment

Contributor

laurocaetano commented Nov 30, 2013

I've tried your branch locally and it seems to fix the issue. What do you think about changing the test to something like @senny did in this comment

@neerajdotname

This comment has been minimized.

Show comment Hide comment
@neerajdotname

neerajdotname Nov 30, 2013

Member

@laurocaetano go ahead and make the necessary changes and feel free to submit a new pull request. Thank you.

Member

neerajdotname commented Nov 30, 2013

@laurocaetano go ahead and make the necessary changes and feel free to submit a new pull request. Thank you.

@vipulnsward

This comment has been minimized.

Show comment Hide comment
@vipulnsward

vipulnsward Nov 30, 2013

Member

@laurocaetano , @neerajdotname I am going ahead and submitting an updated PR.

Member

vipulnsward commented Nov 30, 2013

@laurocaetano , @neerajdotname I am going ahead and submitting an updated PR.

@laurocaetano

This comment has been minimized.

Show comment Hide comment
@laurocaetano

laurocaetano Nov 30, 2013

Contributor
Contributor

laurocaetano commented Nov 30, 2013

@laurocaetano

This comment has been minimized.

Show comment Hide comment
@laurocaetano

laurocaetano Apr 8, 2014

Contributor

I'm closing this PR in favor of #13112.

@neerajdotname thanks for working on this :)

Contributor

laurocaetano commented Apr 8, 2014

I'm closing this PR in favor of #13112.

@neerajdotname thanks for working on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment