sort => sort! on new array #10543

Merged
merged 1 commit into from May 10, 2013

Projects

None yet

2 participants

@vipulnsward
Member

sort => sort! on new array

@carlosantoniodasilva carlosantoniodasilva merged commit 04d2715 into rails:master May 10, 2013
@carlosantoniodasilva

Merged by mistake, but it's there. Next time please describe the commit message a little bit more please. Thanks!

@vipulnsward
Member

Sure, what exactly @carlosantoniodasilva ? This should have included a bm too? Or just bit more informative

@carlosantoniodasilva

It's always good to include why the change is there, ie does not need to create a new object, or performance, etc. Just a small note. In this particular case I'd think a benchmark might not be needed.

@vipulnsward
Member

Thanks, will keep in mind

@vipulnsward vipulnsward deleted the vipulnsward:to_sort branch Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment