Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc. #10556

Merged

Conversation

@Empact
Copy link
Contributor

Empact commented May 10, 2013

distinct was previously used by #construct_limited_ids_condition, but

no more after #6792. #columns_for_distinct is just a utility method for

construct_limited_ids_condition and shouldn't be public.

@rafaelfranca
Copy link
Member

rafaelfranca commented May 11, 2013

Could you add a CHANGELOG entry?

@Empact
Copy link
Contributor Author

Empact commented May 12, 2013

How about that?

…s_for_distinct nodoc.

#distinct was previously used by #construct_limited_ids_condition, but
no more after #6792. #columns_for_distinct is just a utility method for
#construct_limited_ids_condition and shouldn't be public.
rafaelfranca added a commit that referenced this pull request May 12, 2013
…tinct

Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc.
@rafaelfranca rafaelfranca merged commit a93e071 into rails:4-0-stable May 12, 2013
rafaelfranca added a commit that referenced this pull request May 12, 2013
…tinct

Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc.
Conflicts:
	activerecord/CHANGELOG.md
tenderlove added a commit that referenced this pull request May 14, 2013
* master: (61 commits)
  add tests for reset_calbacks
  Fixing build broken by this change
  Extract variable out of loop
  Updated comment to Rails 4
  Fixes NoMethodError: `alias_method_chain` when requiring just active_support/core_ext
  better error message when app name is not passed in `rails new`
  Code cleanup for ActionDispatch::Flash#call
  Fix typo: require -> requires
  Add CHANGELOG entry for #10576
  Merge pull request #10556 from Empact/deprecate-schema-statements-distinct
  Some editorial changes on the documentation.
  respond_to -> respond to in a message from AM::Lint
  specify that dom_(id|class) are deprecated in controllers, views are fine
  copy edits [ci skip]
  Fix class and method name typos
  Replace multi_json with json
  ruby -> Ruby
  Adding documentation to the automatic inverse_of finder.
  Improve CHANGELOG entry [ci kip]
  Call assume_migrated_upto_version on connection
  ...

Conflicts:
	activesupport/lib/active_support/callbacks.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.