Fix detection of engine in rake db:load_config #10640

Merged
merged 1 commit into from May 16, 2013

Conversation

Projects
None yet
2 participants
Contributor

joelcogen commented May 16, 2013

d1d7c86 moved engine detection from the db:load_config task to Railtie, breaking it in the process because ENGINE_PATH is not defined at that point.

As a result, running rake db:migrate from an engine would only run migrations from the dummy app.

This fixes the issue by trying to find the engine in the same way used to define ENGINE_PATH.

@drogus drogus added a commit that referenced this pull request May 16, 2013

@drogus drogus Merge pull request #10640 from joelcogen/master
Fix detection of engine in rake db:load_config
70a3648

@drogus drogus merged commit 70a3648 into rails:master May 16, 2013

Contributor

joelcogen commented May 16, 2013

@drogus BTW, I don't where we are now branch-wise, but I guess this should also be merged in 4-0-0 or 4-0-stable?

Member

drogus commented May 16, 2013

Yes, it needs beckporting, I'll push it to both branches

Member

drogus commented May 16, 2013

@joelcogen before I backport, could you confirm that the issue is fixed with also with 89f558c?

Contributor

joelcogen commented May 17, 2013

@drogus Yes, everything works for me

bcardarella referenced this pull request in travis-ci/travis-ci Jun 10, 2013

Closed

Travis not running all migrations #1148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment