Fix XmlMini different backends tests #10727

Merged
merged 1 commit into from Jun 15, 2013

Conversation

Projects
None yet
4 participants
Contributor

pacoguzman commented May 22, 2013

Currently in some of the tests for each backend we're comparing the parsed result with the result of the default backend 'REXML' but the implementation of the helper method used to do that I think is wrong.

This PR fix that problem

Contributor

pacoguzman commented Jun 14, 2013

Someone have any comment about this?

Member

schneems commented Jun 15, 2013

Can you give more info? Why is the test case currently "wrong"?

Owner

rafaelfranca commented Jun 15, 2013

ahh, make sense.

@schneems the hash value will be always equal to parsed_xml because they are the same 😄

@rafaelfranca rafaelfranca added a commit that referenced this pull request Jun 15, 2013

@rafaelfranca rafaelfranca Merge pull request #10727 from pacoguzman/fix-xml-mini-tests
Fix XmlMini different backends tests
eabbfb2

@rafaelfranca rafaelfranca merged commit eabbfb2 into rails:master Jun 15, 2013

@rafaelfranca rafaelfranca added a commit that referenced this pull request Jun 15, 2013

@rafaelfranca rafaelfranca Merge pull request #10727 from pacoguzman/fix-xml-mini-tests
Fix XmlMini different backends tests
62c1e6c
Member

arunagw commented Jun 15, 2013

Broke the build.

Owner

rafaelfranca commented Jun 15, 2013

@pacoguzman could you please fix it?

Contributor

pacoguzman commented Jun 15, 2013

Yes, I'll do
On Jun 15, 2013 10:35 PM, "Rafael Mendonça França" notifications@github.com
wrote:

@pacoguzman https://github.com/pacoguzman could you please fixt it?


Reply to this email directly or view it on GitHubhttps://github.com/rails/rails/pull/10727#issuecomment-19502997
.

Contributor

pacoguzman commented Jun 15, 2013

@rafaelfranca should I open a new PR with the fix, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment