Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
using `#joins` does not imply `readonly = true`. #10769
Before this patch using
Author.joins(:posts) # SELECT authors.* FROM ...
As far as I can tell there is no reason we need to mark these records as
referenced this pull request
May 27, 2013
I personally find that
Finding out all the cases were
@senny while you are at it, please also cleanup usage of
Add something like this to change log
I'm +1 on this PR.
@rafaelfranca if there is any select then
Parsing the select statement to see which of the columns belong to primary table and which ones belong to join table will be brittle and error-prone. Hence my take that lets leave it upto the user.
@rafaelfranca what do you want to have covered in the guides? you no longer need