Extracted attributes assingment from ActiveRecord to ActiveModel #10776

bogdan · 2013-05-28T07:39:05Z

Now you are able to do:

class Feedback
  include ActiveModel::AttributeAssignment
  attr_accessor :email, :subject, :body
end

f = Feedback.new
f.assign_attributes(
  :email => "bogdan@example.com", 
  :subject => "Hello", 
  :body => "The app dont work for me"
)

This is just a proof of concept PR.

There is still some todos:

Write tests for ActiveModel::AttributeAssignment
Deprecate AR::UnknownAttributeError in flavor of AM one
Add change log entry
rebase change log entry 2-3 times

I am gonna add them if this will be approved to merge in.

dmathieu · 2013-05-28T07:49:26Z

activerecord/lib/active_record/errors.rb

-    end
-
-  end
+  UnknownAttributeError = ActiveModel::AttributeAssignment::UnknownAttributeError


I don't think this is still necessary.

Existing rails apps could still use this constant to catch this exception and process it manually.

Raising it has to trigger a deprecation then.

Do you know how to do that?

dmathieu · 2013-05-28T07:57:21Z

Is there a reason why you didn't extract the tests too ?

bogdan · 2013-09-25T15:15:12Z

@dmathieu once I saw someone from core team saying that overlapping between AR and AM tests is good idea. No concrete reason.

robin850 · 2013-09-28T13:09:05Z

activemodel/lib/active_model/attribute_assignment.rb

+
+    private
+
+    def _assign_attribute(k, v)


Could you please indent the private methods as the contribution guideline states ? Also, I think that this will at least need a changelog entry. Not sure if you should add one in AR changelog as well.

Nice pull request though, thank you!

rafaelfranca · 2015-01-21T21:33:57Z

What is the motivation for this extraction?

bogdan · 2015-01-21T21:41:04Z

Using outside of activerecord just like validation and others:

Attributes assignment concept is something I personally use a lot for many types of objects.

rafaelfranca · 2015-01-21T21:44:46Z

👍 for the idea from my side. @sgrif WDYT?

sgrif · 2015-01-23T05:08:07Z

👍 for the idea from me, as well. Would like to review the code again once it's been rebased onto master and had tests added/moved/etc

bogdan · 2015-01-23T12:02:18Z

Updated the PR:

Rebased with master
Added tests for ActiveModel
Decided to keep a separated documentation for #attributes= in activerecord because it includes many DB interaction points
Left ActiveRecord::AttributeAssignment tests untouched that now creates some overlap in tests. Thought it is a good idea
Made changelog

arthurnn · 2015-01-23T14:55:38Z

I would use this on Mongoid if this is merge on ActiveModel.!

rafaelfranca · 2015-01-23T17:05:07Z

activemodel/lib/active_model/attribute_assignment.rb

+      _assign_attributes(sanitize_for_mass_assignment(attributes))
+    end
+
+    def _assign_attributes(attributes)


Should not this method be private?

bogdan · 2015-01-23T20:19:44Z

@rafaelfranca removed all whitespace

vipulnsward · 2015-01-23T20:38:49Z

activemodel/CHANGELOG.md

@@ -1,3 +1,23 @@
+*   Extracted `ActiveRecord::AttributeAssignment` to `ActiveModel::AttributesAssignment`


AttributesAssignment => AttributeAssignment

vipulnsward · 2015-01-23T20:42:31Z

activemodel/lib/active_model/attribute_assignment.rb

+    #   cat = Cat.new
+    #   cat.assign_attributes(name: "Gorby", status: "yawning")
+    #   cat.name # => 'Gorby'
+    #   cate.status => 'yawning'


…utesAssignment` Allows to use it for any object as an includable module.

Minor style changes across the board. Changed an alias to an explicit method declaration, since the alias will not be documented otherwise.

Extracted attributes assingment from ActiveRecord to ActiveModel

egilburg · 2015-01-23T21:58:21Z

❤️

egilburg · 2015-01-23T22:01:37Z

I wonder if, once all non-db-specific logic (including recent one such as the user-facing casting half) is extracted to AM, it would make sense to have a more full-featured out-of-the-box implementation of active model for those that want it to behave not just as a form object but as much as a full AR as possible, except not persisted. That means all the same validations/errors, attribute assignment, casting, etc.

Perhaps call it ActiveModel::Base which would be a richer implementation than ActiveModel::Model, possibly extending it.

egilburg · 2015-01-24T10:35:47Z

activerecord/lib/active_record/errors.rb

-  end
+  UnknownAttributeError = ActiveSupport::Deprecation::DeprecatedConstantProxy.new( # :nodoc:
+    'ActiveRecord::UnknownAttributeError', 
+    'ActiveModel::AttributeAssignment::UnknownAttributeError'


Given that end users may be rescuing from this error in their apps, it seems like a rather long and implementation-specific namespace. Perhaps keep it under ActiveModel::UnknownAttributeError?

Yep, I agree there ; this is too implementation-specific! 👍

Agreed, let's leave this undeprecated, and just alias it. It's an unnecessary change for users, and forces them to care too much about implementation.

@robin850 Would you care to open a PR?

Leaving this undeprecated can cause confusion because while constant alias will work the caught exception instances will still have new name. It looks like people are just yelling about too long name space and want it to be sorter like in @egilburg's comment

active_model/forbidden_attributes_protection is not used since rails#10776

Remove redundant require: follow #10776

dmathieu reviewed May 28, 2013
View reviewed changes

robin850 reviewed Sep 28, 2013
View reviewed changes

bogdan mentioned this pull request Feb 13, 2014

Raise custom exception instead of NoMethodError when pass wrong parameters bogdan/datagrid#89

Closed

rafaelfranca added activemodel activerecord labels Jan 21, 2015

bogdan force-pushed the assign-attributes branch from 609006e to 4c14289 Compare January 23, 2015 11:58

rafaelfranca reviewed Jan 23, 2015
View reviewed changes

rafaelfranca added this to the 5.0.0 milestone Jan 23, 2015

bogdan force-pushed the assign-attributes branch from 4c14289 to f39d770 Compare January 23, 2015 20:19

vipulnsward reviewed Jan 23, 2015
View reviewed changes

Extracted ActiveRecord::AttributeAssignment to `ActiveModel::Attrib…

2606fb3

…utesAssignment` Allows to use it for any object as an includable module.

bogdan force-pushed the assign-attributes branch from f39d770 to 2606fb3 Compare January 23, 2015 21:43

sgrif merged commit 2606fb3 into rails:master Jan 23, 2015

sgrif added a commit that referenced this pull request Jan 23, 2015

✂️ and 💅 for #10776

a225d4b

Minor style changes across the board. Changed an alias to an explicit method declaration, since the alias will not be documented otherwise.

sgrif added a commit that referenced this pull request Jan 23, 2015

Merge pull request #10776 from bogdan/assign-attributes

8c83bd0

Extracted attributes assingment from ActiveRecord to ActiveModel

egilburg mentioned this pull request Jan 23, 2015

Use attribute assignment module logic during ActiveModel initialization. #18663

Merged

egilburg reviewed Jan 24, 2015
View reviewed changes

robin850 mentioned this pull request Feb 25, 2015

Follow-up to #10776 #19077

Merged

yui-knk mentioned this pull request Jun 7, 2015

[ci skip] Fix Active Model -> Active Record #20465

Closed

rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015

This was referenced May 14, 2018

Rails server does not start when multiparameter_extension is enabled in Rails 5 adzap/validates_timeliness#164

Closed

Fix issue#164 Enable multiparameter_extension issue in Rails 5 adzap/validates_timeliness#165

Closed

yskkin added a commit to yskkin/rails that referenced this pull request Mar 15, 2023

Remove redundant require: follow rails#10776

db944ce

active_model/forbidden_attributes_protection is not used since rails#10776

yskkin mentioned this pull request Mar 15, 2023

Remove redundant require: follow #10776 #47683

Merged

4 tasks

jonathanhefner added a commit that referenced this pull request Mar 15, 2023

Merge pull request #47683 from yskkin/patch-3

8986050

Remove redundant require: follow #10776

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extracted attributes assingment from ActiveRecord to ActiveModel #10776

Extracted attributes assingment from ActiveRecord to ActiveModel #10776

bogdan commented May 28, 2013

dmathieu May 28, 2013

bogdan May 28, 2013

dmathieu May 28, 2013

bogdan Feb 13, 2014

dmathieu commented May 28, 2013

bogdan commented Sep 25, 2013

robin850 Sep 28, 2013

robin850 Sep 28, 2013

rafaelfranca commented Jan 21, 2015

bogdan commented Jan 21, 2015

rafaelfranca commented Jan 21, 2015

sgrif commented Jan 23, 2015

bogdan commented Jan 23, 2015

arthurnn commented Jan 23, 2015

rafaelfranca Jan 23, 2015

bogdan commented Jan 23, 2015

vipulnsward Jan 23, 2015

vipulnsward Jan 23, 2015

egilburg commented Jan 23, 2015

egilburg commented Jan 23, 2015

egilburg Jan 24, 2015

robin850 Jan 31, 2015

sgrif Jan 31, 2015

sgrif Jan 31, 2015

bogdan Jan 31, 2015

		@@ -1,3 +1,23 @@
		* Extracted `ActiveRecord::AttributeAssignment` to `ActiveModel::AttributesAssignment`

Extracted attributes assingment from ActiveRecord to ActiveModel #10776

Extracted attributes assingment from ActiveRecord to ActiveModel #10776

Conversation

bogdan commented May 28, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmathieu commented May 28, 2013

bogdan commented Sep 25, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelfranca commented Jan 21, 2015

bogdan commented Jan 21, 2015

rafaelfranca commented Jan 21, 2015

sgrif commented Jan 23, 2015

bogdan commented Jan 23, 2015

arthurnn commented Jan 23, 2015

Choose a reason for hiding this comment

bogdan commented Jan 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

egilburg commented Jan 23, 2015

egilburg commented Jan 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment